5.11 edit albums sort options

[Astaran]

The sort options while editing an album aren't language dependent.

[Chuck S]

I do not beleive the sort box anywhere in the program is language dependant since the sort table descriptions are in English in the database. If this indeed is what you are talking about.

if ($sortid == $sortorder) {
$sortdefault = "<option selected=\"selected\" value=\"$sortid\">$sortname</option>";
$sortcode = "$sortc";
}
else {
$soptions .= "<option value =\"$sortid\">$sortname</option>";
}

[Michael P]

The order options come from the database, which is not language dependent.

[Astaran]

But you agree with me that the options in the select box should be language dependent as all texts that are displayed to the end user?

I think it would be sufficient to add language strings for earch order option to the language file as slightly alter the check which one has been choosen.

[Michael P]

Since the strings are stored in the database, we never built a rewrite for them; but it's something we'll consider in an update.

[Astaran]

Here's my quick implementation for it:

in useralbums.php line 179:

$sortdefault = ""; $soptions = "";
while ( list($sortid, $sortname, $sortc) = mysql_fetch_row($resultc) ) {
$optionName = "sort_order_" . $sortid;
if ($sortid == $sortorder) {
$sortdefault = "<option selected=\"selected\" value=\"$sortid\">{$Globals['pp_lang'][$optionName]}</option>";
$sortcode = "$sortc";
}
else {
$soptions .= "<option value =\"$sortid\">{$Globals['pp_lang'][$optionName]}</option>";
}

add to language files:

$Globals['pp_lang']['sort_order_1'] = "Most Active";
$Globals['pp_lang']['sort_order_2'] = "Latest";
$Globals['pp_lang']['sort_order_3'] = "Most Views";
$Globals['pp_lang']['sort_order_4'] = "Most Popular";
$Globals['pp_lang']['sort_order_5'] = "Random";
$Globals['pp_lang']['sort_order_6'] = "Least Popular";
$Globals['pp_lang']['sort_order_7'] = "Image Name";
$Globals['pp_lang']['sort_order_8'] = "Title";