5.11 issues with search(FIXED)

[Astaran]

The search isn't working properly at the moment.

Restricting the time range doesn't have any effect on the search results.
It seems, that the variables $when and $whenterm need to be added to the typecast call in search.php and showgallery.php

I think the same applies to categories. Although this can be an array when someone chooses multiple categories on the search page.

The paging links to browse the search results aren't containing all needed variables also.

For some reason, it's working here.
But not on my installation and not at http://www.viperalley.com/gallery/search.php

Maybe that's because of the vbulletin integration used here?

[Michael P]

line 19 in search.php should probably read:

Content visible to verified customers only.

which adds those two variables.

[Astaran]

Yes, I tried that. Also tried to add in in showgallery.php, but it doesn't seem to fix it.

[Michael P]

I don't think they need to be added to showgallery.php, showgallery.php looks like:

Content visible to verified customers only.

I'll update ViperAlley with current stuff and see what happens when I try it there.

[Chuck S]

I beleive the file edited should be search.php and showgallery.php and adding both those variables fixes the issue for me.

Basically showgallery is missing whenterm

[Astaran]

Yes, that fixed it.
In showgallery, it has to be added to typecast($_REQUEST...
Did that wrong at first.

[Chuck S]

Glad to assist

Members galleries sets the cat variable absolute to 500 to return album photos it has to be all categories

[Astaran]

Here's another one for you:

While testing that I noticed that choosing "member galleries" as category doesn't return any photos in albums. Is that intended?

[Chuck S]

LOL you moved your post and I already answered it.

[vicos]

In 5.12, search.php you have:

'when' => INT

This causes the resulting URL to read:

when=0

as opposed to:

when=

This causes the search to FAIL.

Changing to:

'when' => STRING fixes it

[Michael P]

'when' is suppose to be an integer, which URL are you referring to?

[LMer]

In search.php if $when = 0 (the default value if no time frame is specified), a search URL is generated that contains the argument 'when=0' which causes searches to fail.

I worked around the issue by setting $when to null if $when=0
I added the following to line 236 of search.php:
if ($when < 1) {$when = "";}

After the code change, searches worked fine.

[Chuck S]

Actually I beleive the correct approach since search takes place actually in showgallery is to find this line and add in bold

if ( !isset($when) || $when < 1 ) $when = "";

[LMer]

Either way, it would be nice to see it fixed in the next release.