upload limit problem(fixed)

quasan · June 17th, 2005, 04:27 PM

Hi!
several members of my gallery can't upload any images. The script says that they have reached their upload limit for this day.

There is actually an upload limit set per day, but neither of them uploaded any pics the last days. The limit is set to 10 and they cannot upload to some categories, but to some cats they can...

Rids · June 17th, 2005, 04:44 PM

Same here, some of my members are complaining that they can't upload anything because of reaching their 3 per day limit yet they have not uploaded anything for days. I brought this up the other day but the general opinion was that it wasn't the script that was causing it. However, this has only started happening since I updated to PP5.11 and unlike the other day my server has not had any MySQL problems so I'm more inclined to believe its a script bug that's crept in with the update.

Running PP5.11 integrated with vB3.06

quasan · June 17th, 2005, 04:49 PM

yep sounds familiar to me

I am using pp5.11 and vb3.07

Chuck S · June 17th, 2005, 05:34 PM

Well nothing has changed since this has been added

Code:

Content visible to verified customers only.

This is a simple query here that is run when uploadlimit is greater than 0 in uploadphoto.php. Basically the upgrade had to do with variables passed on the script not variables defined by queries so there can not be an error. Try running that query for the user in phpmyadmin and see what you get.

SELECT COUNT(*) FROM photos WHERE userid=102 AND date > UNIX_TIMESTAMP( DATE_SUB(NOW(), INTERVAL 24 HOUR) )

Basically this will bring a count back.

$User['uploadlimit'] is set in usergroup options

if ( $uploadchk >= $User['uploadlimit'] ) {

I dont know of any way to spoof or fool this query as its not changed even when it was a hack that I designed way back.

quasan · June 17th, 2005, 05:47 PM

hm just ran the sql on one user who has that problem.. it returns 0 because he didn't upload anything. so I tried to upload a pic to the cat "nature"
"uplimit exceeded"

uploaded it than to the cat "members"

and it worked

very strange

)

Chuck S · June 17th, 2005, 05:53 PM

That would be indeed strange as uplimit is a global variable and not category dependant variable

Let me do some testing

quasan · June 17th, 2005, 06:09 PM

yep

i can give you an account if you want

for now I removed the upload limit 'till we find something

Chuck S · June 19th, 2005, 10:57 AM

Okay fix is pretty simple.

At line 289-290 of vb3.php where we initialize some variables add this

$User['uploadlimit'] = 0;

That should take care of the issue.

Rids · June 19th, 2005, 12:27 PM

Schweet! This should placate the ravening hordes

aberg · June 19th, 2005, 12:54 PM

Quote:

Originally Posted by omegatron

Okay fix is pretty simple.

At line 289-290 of vb3.php where we initialize some variables add this

$User['uploadlimit'] = 0;

That should take care of the issue.

Problem also here and this solution don't work for me.
Any other idea what the problem can be?
I also updated to v511 and integrated with vB3.07 seperate database

Chuck S · June 19th, 2005, 01:08 PM

Hello

I run VB3 and this surely solved the issue for me here as I had the same issue when I checked into this and I tested on multiple installs this fix before posting this resolution. Problem was not initializing the variable so I went back through to an old version 4.8 to see what was missing. The only difference was this one line as noted. I then tested on my VB3 and it works as expected.

I will wait for others to test here in this thread that have reported it but so far I see no other issues here.

I suggest you run the query in uploadphoto.php for a specific user on the upload limit and see the results you get as I previously stated. Sometimes one does not realize they actually uploaded that many photos in a 24hour period. Always the first thing to check before moving on.

With this fix I very simple tested this. I registered a regular user account on my VB. I as admin set uplimit to 2 per day. I then uploaded a photo without the fix and encountered the issue sporatically as others noted. I then initialized the variable and deleted all photos and tried again. It worked as expected. At least this is what I found in my testing.

Chuck S · June 19th, 2005, 05:03 PM

aberg

If you still have an issue with this PM me a link to your install and admin login as well as any necessary server info to go in any check on this.

Rids · June 19th, 2005, 05:46 PM

One of my members just reported getting the warning after uploading two images and his last previous image was on June 6 - my limit is set at 3 per 24hrs.

Chuck S · June 19th, 2005, 08:24 PM

Can you replicate it?

If you set your usergroup to say 2 upload 2 images and then see if it stops you after the second image then delete one image and try uploading again. You should be able to upload a second and then be stopped again.

Chuck S · June 19th, 2005, 08:37 PM

Rids

I know your site so I registered a username Omegatron and did 3 uploads and tried to upload a fourth and was stopped. I deleted one and uploaded again for a total of 3 and tried again and was limited so everything works as expected from what I see.

Try checking that user through phpmyadmin running that query and see what you get for him.

Rids · June 19th, 2005, 08:38 PM

I upped your account to admin at Terra

Chuck S · June 19th, 2005, 08:45 PM

Nothing looks wrong that I see. As a registered user I was restricted to 3 uploads per day

Rids · June 19th, 2005, 08:46 PM

Which is as it should be so why Phoenix2 should get the warning after only two is puzzling to say the least.

Chuck S · June 20th, 2005, 09:26 AM

Thats why I stated to run the query in phpmyadmin to see what the query returns

quasan · June 20th, 2005, 09:49 AM

ok I added the line and hope to get some feedback from my users soon