Breadcrumb issue

[moonclamp]

This issue was reported before ...

Member Gallery breadcrumb

When viewing a member gallery, lets say Grae's gallery, I am getting an error in the breadcrumb. Instead of reading "Member Galleries >> Grae's Images", I am getting "Member Galleries >> 's Images". I think this may have started after upgrading to 1.0.2. Anyone else having the same problem?

Anyway, I'm experiencing the same on an upgrade to the latest version - the suggested edit was already applied.

I get similar when reporting a post too.

Using php5 - VB 3.7.3

[moonclamp]

no support for this issue then?

[Chuck S]

The fix was posted in that thread which is way old.

You would need to post an explicit link to what you beleive your issue is and explain it because it would not be that problem.

78cabbageanthelialeather021003 383438 - PhotoPost vBGallery

I am showing my name correctly displaying in the breadcrumb on the test site I setup.

[moonclamp]

Well firstly, that fix was posted years ago - and the current version of browseimages.php already contains the "fixed" code.

Secondly, I don't want to link my site onto this forum as a matter of privacy. I felt that my explanation would have been enough.

Thirdly, the link you showed me is not the current version of VB - I am using 3.7.3

[Chuck S]

The vbgallery has nothing to do with vb 3.7 or vb 3.73

The link I showed was to show that my name is indeed in the gallery breadcrumb and showing correctly

As noted if you have an issue you need to supply information so we can assist you. From what your explaining that I understand my link shows things working as they should so I would need to see links to your site.

[Luciano]

Originally Posted by moonclamp

Well firstly, that fix was posted years ago - and the current version of browseimages.php already contains the "fixed" code.

well i am using newest of both.. vbgallery AND vbulletin and it works!!

Are u using the current version of vbgallery?.. did you do major upgrade? small upgrade (from 2.42 => 2.43) or fresh install..
Just asking because it could be.. if you did an install from 1.02 to => 2.43 .. there could have been some issues as user infos are stored in new tables..
Anyway try to run maintainance tools in ACP.. like update names, gallery cache etc.. etc.. etc.. sometimes that helps..

- other hints to check.. :
in showimage.php look for $plurals
i had a once a plugin (another hack that was using the stringname and overwriting it.. (in your case $plurals)
do a test disabling all products except gallery..


Luc
@chuck

Originally Posted by Chuck S

The link I showed was to show that my name is indeed in the gallery breadcrumb and showing correctly

Well actually it doesn't .. there still maybe is a teeny weeny small bug..
I wouldn't have noticed if you wouldn't have posted the link...
BUT english is NOT my mother tongue...

it says: Chuck S (View all of Chuck S's images) or Chuck S's Images in the breadcrumbs..

This is correct.. because S would be your lastname.. and you would assume that there is a . at the end..
But i think it would be same if your nick was ChuckS (without the space)

in that case it should be:
ChuckS (View all of ChuckS' images) or ChuckS' Images in the breadcrumbs.. (without the trailing s)

If the nick was Chucks it would work out correctly
BUT as it doesnt check for capitalization.. it would then put out the s after the '.

ChuckS (View all of ChuckS's images) or ChuckS's Images in the breadcrumbs.. which I think is wrong.. (but maybe I am wrong)


in the code it looks for

Content visible to verified customers only.

but you have a capital S so it wont apply...

the fix would be:
As the username can contain (foreign language - if allowed by admin) special utf-8 characters we use vbstrtolower instead of strtolower ( thats vbstandard for usernames)

in browseimages AND showimage ..
replace ALL instances of

Content visible to verified customers only.

with

Content visible to verified customers only.

i think you need vbstringtolower (it uses the mb_string extension if exists.. but you dont need the mb_substr as you only get the last character if it is a non special utf-8 character i.e. 's'.

Attention there might also be a couple of iif(substr($post['musername'], -1) => would need change to iif(substr(vbstrtolower($post['musername']), -1)

I will do some test on my localhost install...

Luc

[Chuck S]

Luciano my name shows fine and vbulletin vbgallery show it correct. Remember they are not going to consider what is a first last name etc its a username so your always suppose to have a 's after the name no matter what it is

[Luciano]

well in that case the thing is wrong as it is ...

try a username with a small s at the end.. and it will show (assuming username is Chucks) it will show: Chucks' gallery... and NOT Chucks's gallery

what i am trying to say: AS IS.. without any modification Vbgallery will do following:
if username is Chucks it will display: Chucks' Gallery
if username is ChuckS it will display: ChuckS's Gallery

whatever the correct way to write it is.. it should display the same.. no matter if the s at the end is capitalized or not.. thats all..

Luc
-----------------
PS: I know that the system doesnt know its last name or not.. i wasnt referring to the system but to english grammar rules..

if "ChuckS's Gallery" is correct.. then it should display "Chucks's Gallery" also. In that case we should remove the conditional below.

but if i recall my schooltime (i had english as a foreign language) we were told that if the word ended with an s.. it would be the ' only...
if that is correct the we keep the conditional in the code but add the vbstrtolower.

the code that does it in showimage.php original code:
if ($categorycache["$image[catid]"]['membercat'])
{
$navbits['browseimages.php?' . $vbulletin->session->vars['sessionurl'] . "c=$image[catid]&userid=$image[userid]"] = construct_phrase($vbphrase['usernames_images'], $image['username'], iif(substr($image['username'], -1) != 's', $vbphrase['plural_s']));
}

as an example... but there are more instances

[moonclamp]

Thanks for this, just a quick reply as I'm very busy at the mo.

It was a major upgrade vb 3.5.0 and VBA_gallery from when Brian used to have it (unsure of the version) to the latest of both. As soon as I get a chance I'm gonna have a look through all your suggestions. Cheers.