[RC2] Unable to upload some SWF files

[KW802]

The Problem
I recently came across a problem where I was unable to upload one particular SWF file even though I've done it before with no problems and I confirmed that the SWF file type was still in my settings.

The Cause
A little research little and I found out that there are some SWF file that are really SWC files but they have an extension of SWF. They have the wrong extension so that they'll play in your browser's flash viewer as normal. Depending upon what site you go to SWC files are defined as being either component files or compressed files but, when they have an SWF extension, they behave like any other SWF file would.

Now where it get's interesting is that the Gallery is smart enough to know if somebody is trying to upload a file with the wrong extension! That's a very useful thing to have in there but when uploading these SWC files that have an SWF extension the Gallery will return an "Invalid File Type" error with no further explanation.

The Hacked Solution
Where it associated the file extension (type) to a numeric value is at the bottom of gallery_global.php but I didn't want to mess with anything there because having it know "swf" and "swc" uniquely might be useful someday in the future.

Where it checks the file's extension versus it's actual file type is in the functions_gallery_imageedit.php file (around line 405).

Look for this code:

Content visible to verified customers only.

... and replace it with this:

Content visible to verified customers only.

... and that will take care of the problem for now. What the change does is look for the numerical value assigned to the file type (in this case, "13" for SWC files) and then let's it bypass the error check if the extension is either SWC or SWF. I'm sure Brian & Zach' can offer a cleaner version to take care of it but if you need an interim solution that'll do it.


NOTE: Two things... (1) Before uploading SWF files you'll need to add an entry for SWF in your Gallery settings! (2) If you aren't working with SWF files and if you aren't experiencing any problems then this doesn't apply so there is no point in modifying your code if you don't have to.

Could I get you to email me the file that was causing this so I can do some tests and make sure that won't create a problem in the next version?

[KW802]

Originally Posted by Brian

Could I get you to email me the file that was causing this so I can do some tests and make sure that won't create a problem in the next version?

No problem. Give me a few and I'll send it from my gmail account. A normal SWF file returns a filetype of 4 but this bugger was returning a 13 which led to my path of discovery this morning.

EDIT: You've got mail.

[dieselpowered]

Ok so is this the same issue that I am having?? I am attempting to uload a swf file that is approx 2 megs...I have added the extension in the admincp as well as the max file size, however, when I attempted to upload it says that the file is too large and that the max dimesions at 0 x 0???

Any thoughts??

[KW802]

Originally Posted by xtremeoff-road

Ok so is this the same issue that I am having?? I am attempting to uload a swf file that is approx 2 megs...I have added the extension in the admincp as well as the max file size, however, when I attempted to upload it says that the file is too large and that the max dimesions at 0 x 0???

Any thoughts??

The 0x0 dimensions and the files size are two different problems.

If it's saying that it's too big then either your server doesn't support uploads bigger than X and you need then to instead upload the file via FTP or the file size for SWF in your file types table is too small.

Now if it's saying that it can't be resized and/or is showing 0x0 dimensions then try this: http://www.vbadvanced.com/forum/showthread.php?t=4112

[dieselpowered]

Hi there, my server uploads are set at 40 megs...I have no problem with upload sizes as I have adjusted all the sizes in the table accordingly. Here is the error I am receiving.

"Your image is too large. The maximum dimensions for this type of image in this category are 0 x 0."

Thanks for the help!

[KW802]

Originally Posted by xtremeoff-road

Hi there, my server uploads are set at 40 megs...I have no problem with upload sizes as I have adjusted all the sizes in the table accordingly. Here is the error I am receiving.

"Your image is too large. The maximum dimensions for this type of image in this category are 0 x 0."

Thanks for the help!

When you added SWF to your vBa Gallery types you left the max height & width set to 0.

Your PHP configuration is able to grab the dimensions from the SWF file so it thinks it's over the max you've defined.

BTW: Since your server recognizes the dimensions, you may be interested in this hack.

[Selrahc]

If you add the swf AND swc extensions to the list of acceptable upload extensions, would this bypass the problem? I added swf files to the list, but I have one that gives me the invalid file type error..... probably for the reason you stated above.

Would adding both swf and swc to the ok list allow them to be uploaded? Or would the gallery have a problem with the extension not being what it thinkts it should be? Ill try it when I get a free moment tonight........

[KW802]

Originally Posted by SelRahc

Would adding both swf and swc to the ok list allow them to be uploaded? Or would the gallery have a problem with the extension not being what it thinkts it should be? Ill try it when I get a free moment tonight........

It would still give a problem if the extension is still SWF. The problem is when an SWC file has an SWF extension but if the extensions were correct then it should upload fine. But.... by changing the extension to SWC then most other applications won't recognize it as an SWF anymore. Fun.