Flash Upload - cancel all button not working

DDIG · November 15th, 2010, 01:13 AM

Users report that when they upload photo's using the Flash Upload, the Cancel All button is Gray - nothing happens when you push it.

A photo that is uploaded by mistake (and it is not processed yet) cannot be removed again (that is what the Cancel All button should do, isn't i??)

Please help, why can't I push the Cancel All button?

Luciano · November 15th, 2010, 04:24 PM

hmm.. it works on my install..

as soon as you start uploading, the cancel button activates itself ( that is before the blue surface appears..) actually if you only upload 2 images you wont have time to push it..
if you press it it says cancelled in the field of the files, but the surfaces of the files still appear..

But if you uploaded by mistake, you just, when you process the images uncheck the images when processing (on the next page), and they will be removed. automatically.

DDIG · November 21st, 2010, 05:36 AM

If I upload files (using flash upload) that are too large, I can't remove them from the queue. The Cancel All button serves another purpose, that's clear now. But once the files that are way too large are uploaded, they throw an error page once I choose process. And from that moment on, the files remain in the queue with no means to remove them.

See pictures below:

http://www.d-dig.nl/_robert/pics/schermdump/Image1.png
http://www.d-dig.nl/_robert/pics/schermdump/Image2.png
http://www.d-dig.nl/_robert/pics/schermdump/Image3.png
http://www.d-dig.nl/_robert/pics/schermdump/Image4.png

Luciano · November 21st, 2010, 06:45 AM

First, the files are stored in gallery/userfiles/youruserid
you can delete them there...

for the rest its a problem.. because of the different filetypes.
Flash uploader, if the file is to big, should not process it..
BUT
(that is how this 3rd party software works)
it only has 1 value for maximum filesize..
so the upload script gets the biggest value of maximum filesize of ALL filetypes.
In either.. if you have jpg => 2 MB and png => 0.5 MB then the maximum filesize at upload will be 2 MB (regardless the file you are uploading)
(its vbgallery's php that then checks if the file is to big and throws error)

(we would have to rewrite flashuploader to make it filetype dependant in flash upload)

The workaround would be, to set maximum filesize the SAME for ALL filetypes.

Then it would simply skip files that are to big (it should also give an error on uploading (one that doesnt stop the queue) but it seems not to do it..
(I'll look into that)

If you want to clear the queue every time you reload the upload page.. you could do this:

open upload.php and find:

Code:

Content visible to verified customers only.

replace with:

Code:

Content visible to verified customers only.

What this will do...
it will clear the upload directory every time you reload the upload page.

(ATTENTION: Untested except on my localhost)

Luc

DDIG · November 21st, 2010, 07:03 AM

Perfectly clear, thanks a lot!

I think I'll choose to fill in one filesize to fit all. That is a fine solution for me since I only use 3 file formats and somewhere in the past I've filled in 10MB for BMP files, 512KB for jpeg and png files. I simply set BMP to also use 512KB max and the issue(s) should be solved (for me, that is). I'll go and test this now.

DDIG · November 21st, 2010, 07:10 AM

I have tried, but the flash upload does not skip files that are too large. I have set all file types to 512KB max. When I upload 4 JPEG's around 1 MB each, they are processed. I see the error page, but the files are already queued and they remain on the server with no means for the user to delete them or undo the file upload.

Is this where your script fits in? I am reluctant to try really. Can I safely do this?

Luciano · November 21st, 2010, 08:25 AM

Are u sure you have set ALL filetypes to the same size? even those that are not active???

DDIG · November 21st, 2010, 08:30 AM

Sorry, yes, I am very sure: http://www.d-dig.nl/_robert/pics/schermdump/Image5.png

Luciano · November 21st, 2010, 09:01 AM

just checked your sourcecode... something is interfering with flashuploader...
the settings in template are changed !!!!!!
istead of having an integer for max files or max filesize, if you look at the sourcecode of the upload page you have :

Code:

Content visible to verified customers only.

This workaround vblitteral shouldn't be there...
and all the javascript vars starting with Fix_ should not be there either!!!!!

It should work, but it seems that maybe something is not correctly passed to flash..(like a quote missing or something else)

This is in your template... this is NOT the original template !!! and it seems that the masterstyle template has this also...

Luc

DDIG · November 21st, 2010, 09:09 AM

? Upload.php is a vbGallery script right? I never tempered with that.

This is very strange. I'll look into it right now.

DDIG · November 21st, 2010, 09:15 AM

What file should I check? I can see the template but I don't know what php file is interfering or what php file would be wrong.

DDIG · November 21st, 2010, 09:30 AM

Well with all plugins disabled the effect remains. Files are uploaded, the error page is shown when I choose process, I get the advice to use the back button but there the uploaded files are nowhere to be seen. The upload page however keeps displaying files are in queue, only manual removal from server disables the files as being stuck in queu.

I have re-uploaded all vbGallery V3 RC1 upload files and have not plugins active. I have chosen the default vBulletin template and this is the only thing not working, all other vbGallery things are just fine.

What could be wrong?

Luciano · November 21st, 2010, 09:31 AM

its the template.... not the script

DDIG · November 21st, 2010, 09:31 AM

Sorry I'm lost. Please advice what to do. Revert the script?

DDIG · November 21st, 2010, 09:32 AM

The master template is unchanged, there is nothing to revert to.?

Luciano · November 21st, 2010, 10:17 AM

well if you look at the master.. (or your adv_gallery_flashupload ) template, in both you would have a fix for vblitteral...
now this never was in the original template...
could it be vbseo that did that???? changing the master template?

I looked at your external javascript files and they are all ok.
the problem is.. it is converting a byte value (for maxsize) to bites as if it were kbites.. giving you 524000000 bytes as maxsize..
if course it could be easely fixed by dividing the maxsize /1000
but I dont know why its doing this...
so for the moment dont do anything.. just see if there is a .htaccess file somewhere in the gallery folder.. or subdirectory

Luc

DDIG · November 21st, 2010, 10:39 AM

No I do not believe vbSEO is responsible for that. Therefore, how can I restore the original template, assuming the incorrect version somehow got on my server?

There must be a php file or something responsible for that template wouldnt it? I do not know enough about vBulletin scripting to figure that out. I only know that I followed all guidelines and I've updated vbGallery as it should, but now to the fixing part, how do I fix this.....

Thanks for the time and effort so far, that's just great

DDIG · November 21st, 2010, 10:55 AM

There is one .htaccess with only "RewriteEngine Off" in it at /gallery

The root dir has a vbSEO .htaccess with several rewrite rules that only rewrite url's.

that's all.

All vBulletin values are measured in bytes, not KBytes. So I don't get it.

Please note that you have looked at and cited my http://www.proeftuintje.nl instead of the real live site. Proeftuintje has a testvb install (which is a 1:1 copy of the live site at any point in history off course).

I don't get it at all. If everything seems ok from your point of view and dividing some variable with 1000 maybe I shoud just do that...... Note also that you *can* have a look at proeftuintje, 'cause you should be able to login as admin

Any help would be greatly appreciated

Luciano · November 21st, 2010, 01:09 PM

Yes, well dont do anything for the moment, I will take a closer look, I got servera fixes to apply, and on my install it behaves sometimes like yours.. so I will see how to fix it. (But you will have to wait a week or so..)

As to the Fix.. thing.. the strange modifications in the template, its removed now on your test site.. but it should be on your live site.
It would be interesting to know who did that (it was certainly NOT malicious code) because it seems to be a fix for an older version applied by ??? you should definetly know who is modifying your master templates.!!!
Luc

DDIG · November 27th, 2010, 02:41 AM

Just curious: is there any news on this issue?