Is there any reason not to add a define to php files?
 

Can anyone see any reason that adding to my managecats.php (and another define in the upload.php) would cause any undesirable behavior? I went ahead and added it because I want more control over where/when my gallery button on the navbar displays and so far haven't seen any problem but I'm a novice so I thought I'd better ask.

Also, while we're here, my navbar gallery/forum button modification behaves differently than the ones posted in the cmps 1x forums and it's for Zach's vBulletin 3 classic style so I had to create a new button and edit a different template. Should I post it since there's already others even though mine behaves differently? Should I post the gif image that I made with it or should I not since it's Zach's style? If I should post it, where? In the cmps 1x forum, (it involves adding define statements to gallery php files)?

Im attaching screenshots of my navbar so you can see what Im talking about.

Re: Is there any reason not to add a define to php files?
 

There shouldn't be any reason why adding the THIS_SCRIPT code would hurt anything. If you're just trying to determine if you're somewhere in the gallery though, you might want to try and if condition like this instead:

<if condition="VBA_SCRIPT == 'gallery'">

Re: Is there any reason not to add a define to php files?
 

Thanks for your response Brian. I tried your suggestion, but when I go to the gallery/upload.php or gallery/managecats.php or gallery/search.php,etc then it shows the gallery button. (and yes, I remembered to remove my define() before I tested it.) ;)

What I was doing was making the button show forum as long as you were anywhere associated with the gallery and gallery when you are on the home page or at any of the forum pages such as forum/search.php etc.

Does that make sense?

here's the code I wound up with that seemed to work everywhere the way I wanted it:
I only had to add define() in 2 files, I think to accomplish it.

Would it be ok for me to attach the button that I made or should I ask Zach or would nobody need/want it... :o