Bugs deleting ads

zews · April 24th, 2006, 04:38 AM

I have not deleted ads because I thought ads that were expired where not vivible for users. But I was wrong. In a category, if you go to the last visible ad and them clicks on next ad you will be able to see all the expired ads. This must be a bug?

So then I was thinking that I should delete ads that have expired for more than three days ago.

In Admin -> Approve / Bulk Actions ->Category: Expired Queue

I experience these problems/bugs:

1) All ads show Expired: [todays date]
2) Choosing 28 ads per page and going to the last page to delete. After marking delete on every ad (a mark all as delete would be nice) and clicking submit changes, The page I am sent to is not the Category Expired Queue, but another category. The Per page is reset to 12 per page, and the paging is back to 1.

I have more than 1200 ads that I want to delete, and with all the necessary clicks to delete this is a huge job. A simple command to delete all expired ads older than X days would be nice. Also sending out e-mails when deleting old ads is just confusing for the users, so i had to turn off the global setting to send e-mails. But it would be better just to turn of this when bulk-deleting ads.

I hope future versions will have a better sollution to this problem, but as a quickfix, is it possible to have the script return to the expired queue and remembering per page and page number?

Chuck S · April 24th, 2006, 08:51 AM

Are you running your sendnotice.php cron script? If you run that cron script then expired ads do not show on your install period of this I am sure.

As far as the expired que any expired ad will show and you need to manually delete each ad. I can not specifically test the feature right now but it has not changed in a long time. Perpage is carried to the next page as well as cat and I show both typecast in the present version.

You can send me a PM to see your site

We can always look at ways of improving this in the future.

zews · April 24th, 2006, 09:09 AM

yes, I am running sendnotice.php every 10 minutes.

perpage and cat are carried when clicking the paging numbers, but are reset when I send the form-information to delete ads "submit changes".

zews · April 24th, 2006, 09:14 AM

http://www.photopost.com/forum/showp...9&postcount=12

Other user reporting same problems.

zews · April 24th, 2006, 09:16 AM

Another one posting the same problem:

Better bulk mod options and error fix

Chuck S · April 24th, 2006, 09:27 AM

Well the only bug reported there was fixed that I posted on and that was back in 2.42. The email thing is a feature and you can turn off emails or leave them on thats up to you.

The other thread is a suggestion and was never posted in a bug so it was never seen quite frankly at least by me or I would have responded.

As far as submitting the form and variables resetting try this in adm-misc.php change this line

Code:

Content visible to verified customers only.

to this

Code:

Content visible to verified customers only.

zews · April 24th, 2006, 09:55 AM

Thanks!

I tried to do this, but nothing changed. I noticed that sending the form I am sent to page that confirms my action, and then I am resent back to the Ad approval interface. More changes needed?

These bugs reported are the same as for me;
2) Date expired in expired queue is today for all items
3) after having deleted items pp-c jumps back to the wrong category, this makes it even more difficult to get rid of expired ads

Chuck S · April 24th, 2006, 10:03 AM

I would need to see your install for further comment. What I posted should work to pass those variables to the form. You would need to send ftp info url admin login

zews · April 24th, 2006, 10:40 AM

About ads showing after the have expired you can see the problem here:

http://www.viperalley.com/classified...page=15&stype=

Clicking on page 8 returns page 1 (because of expired ads counted when paging)

Clicking on the last ad on the last page (7)
http://www.viperalley.com/classified...cat=all&page=7

The next ad link is valid and you come to a new ad which are marked as sold and therefore probably expired.
http://www.viperalley.com/classified...1&cat=5&page=7

Clicking further on the next ad link you will find a lot of expired ads...

Is this supposed to be like this?

Chuck S · April 24th, 2006, 11:01 AM

Page 8 and page 1 have completely different ads on that site so I dont see how you deduce they are expired. The showcat page explicitly will only show ads which are approved. It will never show an expired ad. You can see sold ads but that does not mean they are expired.

Code:

Content visible to verified customers only.

See only when you run the sendnotice.php script would ads be moved from approved=1 to approved=2

Code:

Content visible to verified customers only.

If you want help please post your site links here and explain where on display you think something is wrong so I can assist. Given the scenerio your showing on that external site the classifieds appears fine.