VB3 enhanced templates
 

Hello,

I've noticed in a lot of vb3enhanced templates there is

class="$fillcolor[$x]}"

which should be

class="$fillcolor[$x]"

without the curly brace. I think some refactoring went wrong somewhere. I have been through all my templates and fixed it but that's from a live 5.23 copy.

Thanks!

Yes I show 6 templates in that set which had that and that has been corrected thanks.

Off to work so no chance to be more thorough now, but I searched for

}" width

and it turned up a few more I think, I've yet to fix them yet.

Thanks

well there are some variables that should be surrounded with brackets just to let you know. LOL

Heh, I started to have that feeling this morning.

I'll just do the six templates that you mentioned and see if I bump into anything else :)

Thanks

Just fyi, if I search in the root templates folder I find 7 files to fix.

Thanks

what do you mean by root templates folder as there are no files in the root of templates

I already fixed anything related to this in any templates folder in my build.

I mean in the folder above the vb3enhanced folder, so the templates folder itself.

I'm sure you're right, but when I extract a fresh 5.23 I find matches in

templates\forumstyle\bids.tmpl
templates\vb3enhanced\bids.tmpl
templates\vb4enhanced\bids.tmpl
templates\vb3enhanced\showproduct.tmpl
templates\vb3enhanced\showproduct1.tmpl
templates\vb3enhanced\showproduct2.tmpl
templates\vb3enhanced\showproduct3.tmpl
templates\vb3enhanced\showproduct4.tmpl
templates\forumstyle\feedback.tmpl
templates\mobile\feedback.tmpl
templates\classfieds\feedback.tmpl
templates\vb3enhanced\feedback.tmpl
templates\vb4enhanced\feedback.tmpl

Oh and congratulations on your 70k post ;)

Those are not root of templates those are subfolders and yes I already searched and found all those so thanks.

yeah I post alot and the sad thing is we already pruned a couple years from the database here.

If I am not mistaken, (and that happens plenty of times :)) wouldn't it be better to leave the curly braces on rather then off. It should help with some ambiguity to the parser.

No not at all both are valid

{$fillcolor['$x']}

and

$fillcolor[$x]

Part of the new versions was making variables more user friendly and the templating not being so PHP heavy handled but more straight html so users could understand and work with it more.

See how much simpler the second one is rather than the old way of doing it. ;)