Ad expires

Bryan Ex · September 28th, 2012, 07:10 PM

When an ad exires should it not be removed rather than being markerd as sold? I posted a test ad to let it expire and it was marked as sold rather than being removed.

- Bryan Ex

Chuck S · September 28th, 2012, 07:31 PM

Ads are not removed until they are over 2 weeks expired. You must also be using some old version also as ads that are expired are marked approved=4 which are not shown on the product display.

The showcat display only pulls ads with approved are 1 or 2.

Chuck S · September 29th, 2012, 06:24 PM

Bryan did you sort your issue? what version are you using? For instance older version any ad which expired would show as expired as approved was 2 for any ad expired or sold. 3 was for payment pending and 1 for approved. In later versions I added the new 4 for expiring ads and that simple means an expired ad would never be shown in the program and then in 2 weeks it would auto expire as do all expired or sold ads.

Bryan Ex · September 29th, 2012, 08:07 PM

Just looking into it tonight Chuck. I'm almost positive it worked correctly before where an expired ad was dropped online but still available in admin and not marked as sold but I have since made some changes to the URL settings to get Who's Online working correctly in my older version of vBulletin. I did notice that the total sold amount on the index page did not change. The database does show Approved=2 in version 4.21. If this has since changed then just let me know where to look for the code section and I'll port it over to my older customized version. Really appreciate the follow up.

Chuck S · September 30th, 2012, 01:05 PM

You can look at the cron and sendnotice scripts and compare them to your older code as yes things have changed alot in the program since 4.21

Bryan Ex · October 2nd, 2012, 04:56 PM

The changes must be more widespread than just those two scripts if you've added additional approve settings. I may be incorrect but wouldn't the queries in showproduct and showcat also need to be updated along with a function or two to make it work, not to mention adding it to admin in some way? I'll track it all down and make the changes... just trying to figure how widespread those changes will need to be.

Chuck S · October 2nd, 2012, 06:05 PM

I do not think so but then again I am not looking at that older code.

If an ad is expired after you make the changes noted and it has approved = 4 in the database it definately would not be shown.

There is a change in showproduct that might show expired instead of sold in the display with the price.

Chuck S · October 3rd, 2012, 09:36 AM

This is probally what your missing in showproduct.php

Code:

Content visible to verified customers only.

There is also a language string most likely as well so all things you want to check out.

The point I am making though in on showcat where products are listed we only grab sold or approved products. If your cron scripts have been updated and set expired ads to 4 meaning new ones not old ones already expired then they are not shown on the ad listing.

Bryan Ex · October 3rd, 2012, 06:10 PM

Okay, thanks Chuck. That will certainly get me going in the right direction. Just reviewing the change logs to see whether I'm better to upgrade and redo all my changes or port over just this issue for my specific site. My users are not big on change but do expect things to work exactly as they expect. I'll figure out which will be less work then go from there. I know you are not big on anything but current stock scripts so I really do appreciate the insight.

- Bryan

Chuck S · October 3rd, 2012, 06:27 PM

Your definitely better off upgrading and then porting over any mods you do to be compatible with the newer code. There are alot of great additions and style changes etc.

Chuck S · October 4th, 2012, 10:37 AM

PhotoPost Classifieds 5.0 Released 05-29-2012

There are tons of little upgrades since 5.0 with a few new features here there to add into the mix but here is the big one frmo 4.2x to 5.0x