New posts icon

Bryan Ex · September 10th, 2011, 06:18 AM

Not sure if this is a bug or by design. The new post / last post arrow icon on the far right side of showcat page does not change between nonewpost.gif and lastpost.gif to indicate which categories have had new ads listed since my last visit. This function worked in previous PP licenses I've had and I see the function is still included in pp-inc.php around line #1619 but my previous installs were all integrated with vBulletin so I'm not sure if this is supposed to work on a stand alone install of classifieds or if a forum is used to track viewed ads.

Chuck S · September 10th, 2011, 11:40 AM

They do change one has yellow arrow one does not. at least they work for me when I test

Bryan Ex · September 10th, 2011, 02:54 PM

That's what I thought but neither my temporary unaltered test install or my modified live version have ever changed from the grayed out arrow. I just checked reef talk and viper alley and neither of them show any yellow arrows either and it's been a little while since I visited either. It's not a big deal but I'm also not convinced it's working correctly, at least as a stand-alone install.

Chuck S · September 10th, 2011, 07:36 PM

well I will double check but the code is right here

Code:

Content visible to verified customers only.

From what I see as long as you have set to display the new post indicator set to yes on the index it should work the code has never changed.

Bryan Ex · September 10th, 2011, 08:25 PM

The code you posted is an exact match to what I've downloaded, I've checked that display new post indicator is set to yes and that yes is actually entered in the database for displaynew in the settings table. I have also double checked that both nonewposts.gif and lastpost.gif are on my server and that the images are correct. I have tried uploading as one user and then logging back in as another and I have also emptied the laston table... but still no yellow arrow from my posts or from my users posts. It doesn't affect the use of the classifieds but it would be nice to have as things get busier.

Chuck S · September 10th, 2011, 09:16 PM

To actually place a last on entry for a category in the laston table you need to view a category.

Bryan Ex · September 11th, 2011, 09:34 AM

I've replaced the nonewpost.gif with one with a red arrow and kept the lastpost.gif yellow arrow as is. That will at least add a bit of colour to the icon for now and if it starts working for me at some point in the future I will still have a new post indicator.

Chuck S · September 11th, 2011, 09:40 AM

yeah I will keep doing testing but I am unaware of any change.

The way it works is how I outlined. If you visit your gallery and never enter a category it will not work. The code has not changed and it seems to work for me but I need to use multiple browsers etc to make sure all logins are separate and I have seen it work.

Bryan Ex · September 11th, 2011, 10:00 AM

I never thought of the multiple browsers to test with. I'll check that out this evening.

Chuck S · September 11th, 2011, 11:01 AM

Not a problem if I find anything I will comment in this thread.

Bryan Ex · November 8th, 2011, 04:43 PM

Fresh install of 4.21 with a build date of Oct 26 and new posts indicator still does not work. Works fine in gallery version of script.

Chuck S · November 8th, 2011, 05:00 PM

The code is exactly the same as the gallery product for that feature in fact the only code difference between the products is a variable name. My test site works so maybe some more info about your install.

Are you sure you actually have set the option is display new post indicator in admin settings?

Bryan Ex · November 8th, 2011, 05:25 PM

Quote:

Originally Posted by Chuck S

The code is exactly the same as the gallery product for that feature in fact the only code difference between the products is a variable name. My test site works so maybe some more info about your install.

Are you sure you actually have set the option is display new post indicator in admin settings?

Indicate new posts is set to yes in admin. I'm going to compare code between classifieds and gallery to see if I can find what's different. I know you maintain it works on your install but I've now installed both a stand alone and integrated version of 4.2 and now a fresh install of 4.21 and have yet to have it work so it's not because of mods or other edits to the files. I'm willing to bet it's something very minor but enough to make the difference. No worries... beyond compare is my friend.

Chuck S · November 9th, 2011, 06:41 AM

Your looking at the catrow function in pp-inc.php and you will see it is exactly the same except for the variables $isonphoto and $isonproduct. All the code does is load an alternate icon.

Bryan Ex · November 9th, 2011, 06:51 PM

I'm sure it is the same but there is something different in the process. No worries. I will find it now that I have a current benchmark to reference.

Chuck S · November 9th, 2011, 08:12 PM

The code is exactly the same of that I am sure it is all handled by the catrow function.

It works for me I would need to see your database as you need to look for issues with what dates are there. I mean as long as the last product in a category has a date larger than the laston time that a user has recorded for a category they visit then $isonproduct is active and you will see the new product indicator. The code is very easy to follow and there are no coding errors.

Take note you actually have to view a category or product in a category because your laston time is recorded.

That is where I would check in the laston table the dates of the laston times for a user in a category.

Mary303 · November 20th, 2011, 03:18 PM

I am not seeing a yellow arrow either ...

under Index Options, Display new products indicator on index? = Yes

But no yellow arrow has displayed. Let me know what I can do to allow the yellow arrow to indicate a new post. thx

Chuck S · November 20th, 2011, 03:56 PM

My suggestion would be to actually see what is on the laston table. The yellow icon is only going to show for a category where your laston time is before the actual lastproduct of the uploaded ad in that category.

Bryan Ex · November 20th, 2011, 05:09 PM

Laston table works just fine. The error is in PP-inc around line 1616 or so including in the last build of 4.21.

Mary... in pp-inc change the following line

Code:

Content visible to verified customers only.

...to this and the new post indicators will work.

Code:

Content visible to verified customers only.

As mentioned, Beyond Compare is my friend.

Chuck S · November 20th, 2011, 06:08 PM

wow good catch I looked the code up and down but guess I should have put on the reading glasses.

Very tiny typo but that would do it.