Sold ads not expiring?

Badger · October 17th, 2010, 04:16 PM

I have my settings at 45 days for "Number of days to show sold/closed ads?" ...

So, I have ads that go all the way back to early August and they are marked SOLD, but they are still appearing ...

Does that have something to do with the fact that I'm an Admin status and actually regular members don't see them any more?

Regards,
Doug

Chuck S · October 17th, 2010, 06:04 PM

if the day they are marked sold is greater than 45 days then they are shown

Code:

Content visible to verified customers only.

Remember there is nowhere that shows what day an ad is sold. You can not judge the 45 day mark by looking at an ad really.

You can have an ad you posted 6 months ago as a duration but if it was marked say sold 3 days ago it is still going to show for 42 more days since the sold date is not going to be less than your cutoff.

Badger · October 18th, 2010, 06:28 AM

Thanks Chuck ...

I was looking at the date that appears on the ad, so that's most likely the problem. I'll wait to see what happens in a while ...

Regards,
Doug

Chuck S · October 18th, 2010, 07:38 AM

yeah what I will probally do in the future is place the sold date right under the red sold tag

Badger · October 18th, 2010, 10:25 AM

Quote:

Originally Posted by Chuck S

yeah what I will probally do in the future is place the sold date right under the red sold tag

That's a great idea ...

Is that something I can patch into the templates right now?

Regards,
Doug

Chuck S · October 18th, 2010, 10:46 AM

No it is not.

Badger · November 16th, 2010, 11:39 AM

Ok, I still have ads from last August that are marked as SOLD way over 45 days ago, but haven't disappeared as yet?

Is there a manual process (or job) I can run to clear those out, or do I simply go through and manually delete the old ones?

Thanks ..

Regards,
Doug

Chuck S · November 16th, 2010, 01:41 PM

Doug as noted how many days you electing to show sold ads?

Some info would assist because an ads sold date is not shown on an ad.

My suggestion is set the number of days to show sold ads to 0 under admin.

Badger · November 16th, 2010, 04:32 PM

It's set to 45 days, which I assume that means that it will stay shown as SOLD for 45 days from the time a member marks it as SOLD?

The problem is that ads which are well past 45 days having been marked as SOLD are still appearing, at least they show up for me as an Admin. Is it possible that regular members (not Admin) are not seeing them?

If I change it to 0, I assume that means as soon as a member marks it SOLD, the ad will disappear?

Thanks Chuck ..

Regards,
Doug

ps: I have lowered it to 15 days for now as a test, since I do think members should be able to have some time to see that an item has sold before it disappears from the list.

BTW, I checked as a non-registered guest and the SOLD ads appear for them, so I guess it's not an Admin sees them only thing as I suggested above.

Chuck S · November 16th, 2010, 04:47 PM

Doug

The status field says when an ad is sold this has nothing to do with the field of posted date which is enddate. I beleive you where confused by this earlier thinking an ad which was posted x amount of time had expired but was still showing yet when I looked at it when I last responded the ad had just sold.

Like I said without knowing more info I can not really say anything.

For instance if you have an ad that was marked as sold yesterday based on what your telling me that should show on your site for 2 more weeks.

what happens when you set it to 0?

Badger · November 17th, 2010, 06:33 AM

Quote:

Originally Posted by Chuck S

Doug

The status field says when an ad is sold this has nothing to do with the field of posted date which is enddate. I beleive you where confused by this earlier thinking an ad which was posted x amount of time had expired but was still showing yet when I looked at it when I last responded the ad had just sold.

Like I said without knowing more info I can not really say anything.

For instance if you have an ad that was marked as sold yesterday based on what your telling me that should show on your site for 2 more weeks.

what happens when you set it to 0?

Hmmmm...

They don't seem to be disappearing after the timeframe from the date it was sold expires.

I'm not sure, but I will try a test of 0 and see what happens ...

Thanks ..

Regards,
Doug

Chuck S · November 17th, 2010, 08:41 AM

yes you can post a link and test login if you wish but as long as they are in the timeframe specified they will show if not they dont. Then of course ads expired over 2 weeks should be deleted completely off the system after 2 weeks when viewing the admin panel.

Badger · November 17th, 2010, 10:45 AM

Quote:

Originally Posted by Chuck S

yes you can post a link and test login if you wish but as long as they are in the timeframe specified they will show if not they dont. Then of course ads expired over 2 weeks should be deleted completely off the system after 2 weeks when viewing the admin panel.

Ok, I set:

Number of days to show sold/closed ads? 0

Ads disappeared ....

I set:

Number of days to show sold/closed ads? 14

Ads reappeared ....

See attached pic ... what does the 30 mean?

Thanks Chuck ..

Regards,
Doug

Chuck S · November 17th, 2010, 10:48 AM

Okay well that tells me there are ads being returned that are marked as sold in the last 14 days.

Chuck S · November 17th, 2010, 10:55 AM

Example here if you know about phpmyadmin where you can view the products in your database you can run the following query which will tell you how many sold/expired ads that have been expired sold in the past two weeks and should show in a specific category

SELECT * FROM cp_products WHERE status != 0 AND status > 1288760400 AND cat = 30;

Take for instance I used cat equals 30 where 30 is the numeric id off the cat of ads your viewing.

This goes back to the original discussion we had where we found out ad ad was expired sold in the time period you specified.

You can also edit pp-inc.php and the following line

Code:

Content visible to verified customers only.

change that to

Code:

Content visible to verified customers only.

if your debug option is set to display errors as admin you should see all the queries for your page printed in the footer you could post those here and I should show you explicitly why ads show if you do not understand.

Badger · November 17th, 2010, 11:57 AM

Well, you just blew through my skill set ...

I have no idea what you're talking about ...

Anyway, again, what does the 30 mean in post #13? It doesn't seem to relate to the description that appears for it?

Regards,
Doug

Chuck S · November 17th, 2010, 12:16 PM

I was simply saying if you understood how to use phpmyadmin that you could issue a query based on a specific category to understand what sold expired ads should show up. 30 was an example of a categories id. You would replace that with whatever numeric id you wish to explore sold ads expiring in a specific category on your site.

If I knew what site this was I could tell you more as I might even still have access and I know I have worked on your site before but we have 40000 customers so I hardly ever remember whose site is who's without a link.

You can not tell whether an ad should or should not appear based on its posting date which is the only date that is shown. Any ad that is sold or expired in the past two weeks should show on your site. anything that is older would not. Setting your timeout to 0 tells me that your code is working as it should. You should get different results depending on the days you set to show expired ads.

Ads expired over two weeks ago should be deleted from the system when you visit the main admin index of classifieds.

Badger · November 17th, 2010, 01:46 PM

Ok, let's try again ...

In post #13 above there is a pic ....

The pic shows a screenshot of a two options under Admin Option settings...

The description text of the two options is exactly the same ....

The second option shown in the pic, has the number 30 in that field, which I have no idea what it means in relation to the text description in front of it, which apparently is a typo....

So, not knowing what to put in that field, other than 30 which is there, because I have no idea what the text describing it should be, can you tell me what the 30 is for?

Thanks Chuck...

Regards,
Doug

Chuck S · November 17th, 2010, 02:30 PM

Thats something different than what we are discussing here. anyway you should be able to reimport your phrases and solve your wording issue.

I have my cron set to yes and 1440

You can also set up a server level cron from the tutorial in that in the install forum sendnotice.php

Thats just the expiration script and you should be running that to expire ads.

Chuck S · November 17th, 2010, 02:37 PM

Also your site milsurps right? You where allowing no expiration right?

Take this for instance.

YOURSITE/pp-classifieds/g4-want-to-sell.html

You have 18 ads showing 9 per page out of 12 which means there are 3 ads that are older than your electing to show so the code is working as we hide ads older than you elect to show from being displayed. You have a total of 6 sold/expired ads that are showing and should because they have been sold or expired in the timeframe you elected.

Therefore there is nothing wrong here. If your getting too confused as to showing sold ads simply set the option to 0.

Also as noted above if your allow or allowed the no expire option your ads will never disappear that are no expire as there is no way to expire them.