Show Ads by time limit broken?

Badger · May 4th, 2010, 08:22 PM

For the first time, I started testing the viewing of ads by time limits.

For whatever reason, regardless whether I select ANY of the options here:

Recent Ads: last day last 7 days last 14 days all ads

.... the display shows ALL ads?

So, last day as an example, shows every ad in the database going back to April 26th?

Any ideas as to what I may be doing wrong, or is this a bug?

Thanks ..

Regards,
Doug

Chuck S · May 5th, 2010, 08:11 AM

All Ads - PhotoPost Classifieds

Interesting If I do the last day link I get no ads

All Ads - PhotoPost Classifieds

I do last 7 I get none

All Ads - PhotoPost Classifieds

If I do last 14 I get two

Please post a url so I can see your site

Badger · May 5th, 2010, 01:41 PM

Quote:

Originally Posted by Chuck S

Please post a url so I can see your site

It's a development site ...

May I send you login and password via email?

Regards,
Doug

Chuck S · May 5th, 2010, 02:08 PM

sure via the contact us in header

Badger · May 5th, 2010, 02:19 PM

On its way ...

Regards,
Doug

Chuck S · May 5th, 2010, 02:23 PM

No problem you can see as I state mine seem to work

Badger · May 5th, 2010, 02:33 PM

Quote:

Originally Posted by Chuck S

All Ads - PhotoPost Classifieds

Interesting If I do the last day link I get no ads

Interesting ... I see 3 ads for last day, including one going back to March?

Could this be a "client" problem and not a server problem?

Regards,
Doug

Edit: Just moved from FF to Safari and still see all 3 ads clicking your link ...

Will try a Windows XP and IE8 combo now ...

Edit on edit ...

You're going to love this one Chuck ....

It works perfectly on Windows XP running IE8...

It shows ALL ads, regardless of time frame select on Apple MacBook Pro running OSX Leopard 3.6.3 with both Firefox 3.6.3 and Apple's Safari 4.05 ...

Now explain that one to me ...

Chuck S · May 5th, 2010, 09:29 PM

Well maybe related to another change in the script

look at my site you should see no ads for last day

go back in showcat.php use a clean unedited one. remember how I had you do something with approved=1

Using a clean file find approved=1 and replace that with

approved IN (1,2)

Badger · May 6th, 2010, 04:13 AM

Quote:

Originally Posted by Chuck S

Well maybe related to another change in the script

look at my site you should see no ads for last day

go back in showcat.php use a clean unedited one. remember how I had you do something with approved=1

Using a clean file find approved=1 and replace that with

approved IN (1,2)

I actually didn't do that change because the way I did it ended up with errors. Your suggestion was to wait for v4.02 instead.

Here's an additional piece of information, which I don't know whether it will help or confuse more.

I used Windows XP with IE* and checked your demo site. I get the same problem with it. Example, select "last day" and all your ads show up. If I load my site with that browser and OS, it functions correctly, however, I still have the problem with the FF and Safari browsers using Apple OSX on both sites.

There's definitely something wrong that's causing the behavior to work on one set of technology and one site only, versus the other.

I could email you my showcat.php for you to evaluate?

Regards,
Doug

Badger · May 6th, 2010, 06:05 AM

Ok Chuck...

I put your original production copy of showcat.php back and it didn't make any difference. I'm still experiencing the anomalies with the "last x" function and the various operating systems, sites and hardware that I mentioned above.

Of course, by going back to the original, I did lose the nicely added "spacing" between ads that you provided earlier in a mod edit, so I'd like to get those back if I could...

Regards,
Doug

Chuck S · May 6th, 2010, 07:35 AM

doug you can make any mod edit you did by doing it again although I dont think you did any php mods for spacing

anyway the alteration I did is correct in post 8 I am running it right on the site I use for examples to you

I guess if your not going to make the edit you can sent site info and I can pop the showcat file on there for you. remember we are talking php file not template

Badger · May 6th, 2010, 09:17 AM

When I put the original 4.01 virgin showcat.php back, the "spacing" patch you gave me to help separate the ads between the last line of an ad and the start (title) of the next ad disappeared, because of course the "patch" you provided was no longer there.

I just clicked on your demo site and now I'm seeing nothing.

http://www.reeftalk.com/classifieds/showcat.php?cat=all

By that I mean I no longer see any ads at all on your demo site using "all" as above (or even limit=), when viewed from my Apple MacBook Pro running OSX Leopard 10.6.3 with both Firefox 3.6.3 and Apple's Safari 4.05. Before your recent change, I was seeing ALL of the ads regardless of the "limit=" variable, so now the effect is completely opposite.

I sent you to the "contact" information all of the login information for our develop,emt site yesterday?

Regards,
Doug

Chuck S · May 6th, 2010, 09:29 AM

If I visit the link you post I see 6 ads when viewing not logged in

The limit variable must be there as thats the time delimiter.

I will check out emails and see what I find.

Badger · May 6th, 2010, 12:32 PM

This shows 0 ads for me ...

All Ads - PhotoPost Classifieds

After selecting "last 7 and last 14", then once again selecting this:

All Ads - PhotoPost Classifieds

It now shows 2 ads ...

There's something wrong someplace, even on the demo site as it relates to certain browsers and certain platforms?

A caching problem?

Regards,
Doug

Chuck S · May 6th, 2010, 12:45 PM

Do this on your site

Go back to using a stock showcat.php do the links work for you?

I visited your site and your links appear to work when I view them

You have 14 ads

I hit last day I get 0 ads CORRECT

I hit last7 I get 3 ads CORRECT

I hit last14 I get 10 ads CORRECT

I hit all ads I get 14 ads CORRECT

Everything appears to be working fine on your site

Badger · May 6th, 2010, 01:09 PM

Quote:

Originally Posted by Chuck S

Do this on your site

Go back to using a stock showcat.php do the links work for you?

I visited your site and your links appear to work when I view them

You have 14 ads

I hit last day I get 0 ads CORRECT

I hit last7 I get 3 ads CORRECT

I hit last14 I get 10 ads CORRECT

I hit all ads I get 14 ads CORRECT

Everything appears to be working fine on your site

I have 12 ads (see pic) ... 7 active and 5 closed, 2 of which don't show because the "patched" code you posted to get SOLDS to appear wasn't installed for those 2. Since then, closing ads (3 of them) with your patched code, they show. So, I see 10 ads (see pic) of which 3 show as closed ALL the time.

Quote:

Apple MacBook Pro running OSX Leopard 10.6.3 with both Firefox 3.6.3 and Apple's Safari 4.05.

I hit last day I get 10 ads

I hit last7 I get 10 ads

I hit last14 I get 10 ads

I hit all ads I get 10 ads

Quote:

Windows XP with IE8 using Parallels.

I hit last day I get 0 ads

I hit last7 I get 3 ads

I hit last14 I get 10 ads

I hit all ads I get 10 ads

Regards,
Doug

Badger · May 6th, 2010, 01:21 PM

By the way Chuck, unrelated but perhaps you want to open a separate thread....

The drop down box for selection of number of ads per page is broken ...

ONLY when using Windows XP and IE8... see pic and error code text ...

Quote:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB6.4; InfoPath.1)
Timestamp: Thu, 6 May 2010 18:14:24 UTC

Message: Object expected
Line: 413
Char: 1
Code: 0
URI: http://pp-classifieds/showcat.php?cat=all&page=2

Tested same page and screen with Apple MacBook Pro running OSX Leopard 10.6.3 with both Firefox 3.6.3 and Apple's Safari 4.05. Both browsers work fine selecting drop down page and values. Number of ads that display per page works fine with these two browsers, but not IE8 under Windows XP ...

Ain't life grand ...

Regards,
Doug

Chuck S · May 6th, 2010, 01:48 PM

Actually 10 dont know where I got 14 from anyway there are 7 active ads so I am seeing 3 ads which are sold.

The point I am making here is the ads displayed are MOST DEFINATELY the ones suppose to be showing when I go to each of your links.

The timeframes all are correct for me so there is nothing wrong with the scripting.

Here is my thought though because there is only one way to cause your results and thats take limit out of the url you will see what I mean.

I do not use an Apple and have no way to test that however I am unaware of any browser bugs which would change code. The only way to get the results your getting on your apple is whether its the browser or some computer thing the limit variable in the url would have to be negated by your side meaning the limit in the url is not getting back to the script as previously stated

Badger · May 7th, 2010, 12:49 PM

Hi Chuck ...

I don't understand how the Apple OSX could be causing the problem, but it should be noted that it's happening on two different browsers, both FireFox and Safari, plus it's happening on your demo site using Windows XP with IE8, but ONLY on your demo site.

I can't explain why it seems to work fine on my site with the latter (Windows XP nd IE8), but not yours ...

Anyway, I've just downloaded and installed the new 4.02 updated files, so I'll try it again and get back to you.

Regards,
Doug

Chuck S · May 7th, 2010, 01:08 PM

Doug

I explained this above as it does not appear to be a code issue. I use 5 browsers here IE, FireFox, Safari, Opera and Chrome.

Your links all view fine to me under all browsers.

In fact you can try this for yourself under windows browsers to see what I explained in my previous post. the limit variable is the one that contains the timeframe.

showcat.php?cat=all&limit=last7

showcat.php?cat=all&limit=last14

showcat.php?cat=all&limit=last1

no limit means all ads.

Now using your site as the example if hit last7 I get all ads posted in the last week which was 3 when I last looked.

Now if you go to your browsers pull up the url for last7 in your windows browser your seeing 3 ads. In your apple browser your seeing all ads.

Thus it would stand to reason your apple browser is somehow negating the limit variable in the url. To test this go to your windows browser and take the limit variable off the url. You will see all of a sudden you are viewing all ads. Thus that duplicates your issue of seeing all 10 ads instead of the limit passed.

The only way to get the results your getting would be to REMOVE the limit variable from your url.