Previously Correctd bug Returns!

KenDude · July 14th, 2008, 12:21 AM

Chuck,

Remember awhile back I reported that the avatars that display next to someone's name who leaves a comment or question about a classified ad were not displaying, instead they were showing a red x. As I recall we developed a fix for this bug and I manually corrected prior code. However, after updating to the 4.x series the error has returned.

For example see this ad: 2006 Cayman-S, 4,000 miles, MINT CONDITION - Cayman Classifieds

See the question posted by mkiv808? His avatar doesn't show up, it simply shows a red x. What it is trying to display is the following:

http://www.caymanclub.net/customavat...atar9736_0.gif

That is not correct. That member has NO avatar selected, custom or otherwise. For some reason this error has crept back into the code. Can you refresh my memory on how to eradicate it again as well as put this fix into the next code release?

Thanks!

Chuck S · July 14th, 2008, 09:32 AM

Maybe in vb3.php use this codeblock

4.0 series you mean 3.0 series

Code:

Content visible to verified customers only.

KenDude · July 22nd, 2008, 12:22 AM

That seems to work, thanks! Do I need to correct ReviewPost as well, did the same bug creep back in there? I was thinking of ReviewPost when I was thinking 4.x, Classifieds is still on 3.x of course.

KenDude · July 22nd, 2008, 12:30 AM

I'd say looking at this article:
Softronic Plenum Install - My Articles

The answer is yes, we should apply the same fix to the vb3.php file in the reviewpost/forum directory right?

Chuck S · July 22nd, 2008, 08:27 AM

Looking at my reviewpost code I shown it already applied

KenDude · July 22nd, 2008, 09:29 AM

Nope, I just pulled the 4.02 zip file, opened it up, and the code in question is the OLD code see:

Code:

Content visible to verified customers only.

So I will apply this fix as well. Looks like the bug crept back in there as well.

KenDude · July 22nd, 2008, 09:33 AM

Ugh I spoke too soon, I tried to apply that code you posted above in the vb3.php file for reviewpost and while it did fix the red x's for people who had no avatars, it ALSO removed the custom avatars from those who had them, they are not showing up now. Suggestions? I note that the same is true for the Classifieds as well, custom avatars are no longer showing up there either. (see links above for examples)

Chuck S · July 22nd, 2008, 09:35 AM

do you have a code block that you think works as I beleive what we use already works

Jun2520061257 - ReefTalk Gallery

I use a customavatar

http://www.reeftalk.com/forums/custo.../avatar1_1.gif

What paths are wrong here on your site so I can suggest something

KenDude · July 22nd, 2008, 02:17 PM

Well I'm not sure I'll have to see if I can figure it out, but basically our forum is in public_html, not a forums subdirectory. I'll go look at some custom avatars and list their physical locations for you.

Chuck S · July 22nd, 2008, 03:17 PM

Yes since I am using the default code posted and use a custom avatar I would like to see more links etc to see why yours does not work.

Also if you have a product other version of ours other product and it works let me know what your avatar code is in that version?

KenDude · July 24th, 2008, 12:49 AM

Well it doesn't work in ReviewPost, or Classifieds, although I "thought" we had it working in both about 6 months ago, not sure if I have that code laying around though since both products were updated.

Here is the location where my custom avatar resides:

http://www.caymanclub.net/customavatars/avatar3_4.gif

Physically on the server the web root is in public_html

Looking at VBGallery, it doesn't show custom avatars there either. Here is a link to a photo I replied to, you can see that my avatar doesn't show up, and neither does my sigpic.

The Cayman Club

What more can I do to help you fix the bug?

KenDude · July 24th, 2008, 12:56 AM

Ahh I found a backup I did of ReviewPost 3.3 before I upgraded to 4 and went and found the vb3.php file and sure enough the code is different it is:

Code:

Content visible to verified customers only.

Now I am going to go check that and see if it works.

KenDude · July 24th, 2008, 01:02 AM

Yep My code works!!! I knew I had fixed it previously!

PLEASE PLEASE PLEASE integrate this with all of your products!!!

Thanks!

KenDude · July 24th, 2008, 02:03 AM

BTW I looked at vbgallery since it doesn't display any avatars at all and I found this code in showimage.php

Code:

Content visible to verified customers only.

Once the $show[avatar] is set to False it never gets set to True again so nothing is shown. For grins I changed the code to $show[avatar]=true and it tried to show a graphic but the location of the image was not correct, although the hyperlink for the image to my profile was correct. I don't know what that means exactly other than the code listed above doesn't work as intended.

Chuck S · July 24th, 2008, 07:17 AM

I am not really a vbgallery support person feel free to open any issue in the appropriate forums.

As far as reviewpost okay we are talking this line.

Code:

Content visible to verified customers only.

KenDude · July 24th, 2008, 04:35 PM

Quote:

Originally Posted by Chuck S

I am not really a vbgallery support person feel free to open any issue in the appropriate forums.

As far as reviewpost okay we are talking this line.

Code:

Content visible to verified customers only.

Yes that line, and I'll make a post over in the vbgallery area later and draw their attention to this problem.

Chuck S · July 24th, 2008, 07:34 PM

Not a problem.

KenDude · November 6th, 2008, 10:26 PM

Hmm it looks like the 4.03 vb3.php code has the correct code in it to display avatars, now I am wondering why after a site move these aren't rendering correctly?

Chuck S · November 7th, 2008, 05:48 AM

I took a quick look as I posted and I see avatars

KenDude · November 7th, 2008, 08:37 AM

Chuck,

As noted in my email to you, I am NOT running the 4.03 file on my site because it doesn't work. I am running my file from July 24th 2008 that does work, hence you are seeing avatars right now. I sent you both files to compare to figure out why the 4.03 file is broken in that it doesn't display the avatars or the signature pics.