3.0.1 Another mysql error

[Astaran]

We got this error several times now:


An error was encountered during execution of the query:

SELECT id,bigimage,cat,userid,approved FROM cp_products WHERE cat= AND approved=1 ORDER BY disporder,date DESC

The query returned with an errorcode of:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND approved=1 ORDER BY disporder,date DESC' at line 1


I wasn't able to track it down yet, but this type of query is used in showfeature.php, showphoto.php and showproduct.php. Seems that $cat isn't checked before used in the query.

[Chuck S]

I am thinking showframe and that query should be correct we pass $cat to that script it might be an older bug that has been fixed where it might have been using $thecat not $cat

[Astaran]

It's in line 173 (showframe.php)

$query = "SELECT id,bigimage,cat,userid,approved FROM {$Globals['pp_db_prefix']}products WHERE cat=$cat AND approved=1 $sortcode";

That's the only query in showframe.php that matches the error message.
Some guesses here after a quick look at that script:

Maybe using $dbcat will fix that issue?

If that doesn't work, this part looks a bit suspicious:

if ( !$cat && $limit ) {
$cat = $limit;
}

If limit is '', $cat would be set to that value. $limit isn't checked before that statement.

[Chuck S]

I dont beleive that has anything to do with it. This in pp-inc.php for the feature ads display sends a cat variable

Content visible to verified customers only.

I dont see where cat would be empty but basically encapsulating the $cat variable in that query would indeed quiet that error.