Images with watermarks

tomzl · May 28th, 2007, 07:52 AM

Bug Nr. 1
I noticed a bug when using the watermark option. If it is enabled, watermark will be put over the image everytime you rotate it, flip it etc. Even when you click rebuild thumb, it will still have multiple watermarks. Both thumbnail and preview picture are affected by this. The supersize picture is not affected by this because it doesn't even get rotated due to bug #2 (look below).

Bug Nr. 2
Classifieds will only rotate the thumbnail and the preview picture. The largest picture does not get rotated.

Chuck S · May 28th, 2007, 08:09 AM

A Picture gets watermarked permanently on upload. The thumbnail is not watermarked only the preview and supersize.

This is how my testing shows it to work. I would only get watermarked thumbnail if I rebuild thumbs and the large image which is indeed watermarked you create a thumb from that

Files should not be watermarked again because anytime a image is watermarked it is marked as such in the products table

You would definately need to post explicit examples here and a regular test user login

tomzl · May 28th, 2007, 08:35 AM

All three sizes are watermarked on my page (inculding thumbnails). When I go to rotate the picture, it keeps adding watermarks. You can see the result on the last picture in this ad.

http://forum.bmwslo.com/oglasnik/sho....php?product=4

All the other thumbnails are also watermarked once.

In any case, the supersize version of the pic does not get rotated. Look at the first picture in this same ad as an example.

You can test for yourself.
Username: removed
Password: removed

Chuck S · May 28th, 2007, 11:43 AM

well watermarking you would need to check and see what it says in the wmarked field in your products table because if it says yes the file is not watermarked so we need to know more info on what yours is doing as thats not the behavior I get

As far as rotating the supersize image just add this in bold in adm-product.php around line 221 where noted

Code:

Content visible to verified customers only.

tomzl · May 28th, 2007, 01:58 PM

Default value is "No" but for this product (ad) the value in the database for watermark is "Yes".

Chuck S · May 28th, 2007, 02:52 PM

If it says watermarked yes then the file would not get watermarked again.

tomzl · May 28th, 2007, 03:11 PM

Quote:

Originally Posted by Chuck S

If it says watermarked yes then the file would not get watermarked again.

But it does...

Chuck S · May 29th, 2007, 09:51 AM

Try redownloading the build and uploading the main php scripts

tomzl · June 3rd, 2007, 02:39 PM

I redownloaded the build and now all image sizes get rotated but watermarking stopped working and when I try to upload images with an ad I get this error:

Quote:

Warning: Missing argument 5 for create_thumb(), called in uploadproduct.php on line 458 and defined in image-inc.php on line 251

The error is repeated as for each image (3 errors for 3 images). In the end the ad is diplayed and thumbnails are created but still the question remains why watermarking is not working and why this error is even displayed.

Chuck S · June 3rd, 2007, 03:08 PM

try redownloading it

tomzl · June 3rd, 2007, 03:47 PM

Did a clean reinstall with the new build and now the error message is gone but still watermarking is not working.

Chuck S · June 3rd, 2007, 04:24 PM

Make sure you have your watermarking permissions set in edit categories and permanent watermarking on

http://www.reeftalk.com/classifieds/...php?product=29

I did a nice quick test and the image is indeed watermarked

tomzl · June 3rd, 2007, 04:35 PM

It was indeed the usergroups settings. Mea culpa.

Unfortunately I am still getting multiple watermarks when rotating images. This only occurs with thumbnails and preview pictures. The supersize picture works perfect since it gets rotated and only has one watermark.

tomzl · June 3rd, 2007, 04:41 PM

OK, just realized what the problem was with multi watermarks. I added two pics to an ad before changing the usergroups settings and since Classifieds mark the watermarked status for all the pics in the ad and not on per picture basis, the value was still no since one pic wasn't watermarked.

When a new ad was created with a picture, it worked perfect.

All the problems from this thread solved. Thank you.

Chuck S · June 3rd, 2007, 04:53 PM

Yes was just about to post you recheck your end cause I show this to work fine

tomzl · June 12th, 2007, 01:28 PM

Noticed another bug connected to the watermarking. When posting a new ad with multiple pictures, only the first one gets watermarked.

If you edit the ad later and add an additional picture, it gets watermarked but those from before are still left without a watermark.

Chuck S · June 12th, 2007, 02:19 PM

I did a simple test with the code and uploaded an ad with multiple images and both images are indeed watermarked on initial upload

http://www.reeftalk.com/classifieds/...0/limit/recent

tomzl · June 12th, 2007, 03:27 PM

They are watermarked with two different watermarks. How could this be if they were both watermarked at the same time?

Chuck S · June 12th, 2007, 05:16 PM

The second image is an image that is already uploaded to my site and was permanently watermarked.

Both images as I stated are clearly watermarked with that white watermark on the bottom right. That light blue watermark is a way way old watermark from years and years ago

If you want to see this with two sample windows images here try this

http://www.reeftalk.com/classifieds/...php?product=31

that is one I just did

tomzl · June 12th, 2007, 06:00 PM

OK, so what could be the cause for my problems? I uploaded the original files. Which files affect the watermarking so I can reupload them?