Category Unsubscribe Link Broken

queritor · January 27th, 2007, 08:43 PM

The category unsubscription link in emails seems to be broken. Below is the email received. As you can see, there is no ID and clicking on the link results in a 'malformed script' error. The email.php file in languages contains the following:

Code:

Content visible to verified customers only.

Code:

Content visible to verified customers only.

Chuck S · January 28th, 2007, 09:36 AM

Please post what version of the software you are using. This reminds me of a bug that was fixed in an earlier version.

queritor · January 28th, 2007, 09:21 PM

Quote:

Originally Posted by Chuck S

Please post what version of the software you are using. This reminds me of a bug that was fixed in an earlier version.

Version 2.6 downloaded around 2 weeks ago.

I found reference to the problem with a product unsubscription, but this issue is specific to category subscriptions.

Chuck S · January 29th, 2007, 09:32 AM

I am not seeing any issues here. I have tested this and it appears to work and all the variables are correct. This is the language string right in emails.php

Code:

Content visible to verified customers only.

queritor · January 31st, 2007, 11:08 AM

I have confirmed that my code is the same as yours, but the problem persists.

In addition to the missing product ID, I noticed an additional problem. The email notification reads as though the subscriber added the classified.

So if user Paul subscribes to a category and user Fred submits an ad, user Paul gets the exact email shown below. As you can see, it says that Paul uploaded the ad, when in reality, it was Fred.

One other point I should mention is that I'm using this with the vBulletin integration if that makes a difference.

Code:

Content visible to verified customers only.

Chuck S · January 31st, 2007, 11:34 AM

In image-inc.php find this and make the change in bold that corrects the name

Code:

Content visible to verified customers only.

This is the email I get using the category subscription

Quote:

Chuck S has uploaded one or more ads to a category you subscribe to.

Image name: 8468Gonipora5.jpg
Title: test subscribe
Description: Test subscribe

Link to ad: http://www.reeftalk.com/classifieds/....php?product=3

To turn off subscriptions for this category, click on the following link:

http://www.reeftalk.com/classifieds/...ubscribe&sub=2

The Reeftalk.com Team
http://www.reeftalk.com

I would seriously suggest you download the build and reupload ALL FILES except the config files. As I stated earlier I can not replicate the issue and all variables are indeed correct. The subscribe code is sent from image-inc.php where the product is inserted into the database and $realname $title $desc and $lastproductid are all the correct info

queritor · February 7th, 2007, 08:03 AM

After re-downloading the files, this problem is still happening.
I'm guessing the reason you can't reproduce it is because you are not moderating new ads.

If a moderator approves a submitted ad, the email will go out as shown in my earlier posts. The moderator shows up as the ad submitter and the unsubscribe link is broken. The changes you provided seem to have no effect on this behavior.

Chuck S · February 7th, 2007, 09:30 AM

Your talking about a totally different area then and that helps alot.

In adm-misc.php find and add or change in bold

Code:

Content visible to verified customers only.

queritor · February 8th, 2007, 05:44 PM

OK, that almost fixed it.

The product ID is now showing in the unsubscribe link, but the email still indicates that the email recipient submitted the ad.

I've gone ahead and made a similar change in adm-misc.php to the one you described for image-inc.php. I replaced the $nuserid with $result['userid']. Hopefully that will fix it once and for all.

Chuck S · February 8th, 2007, 06:05 PM

Did you make the change I noted in post 6

to image-inc.php I think you forgot that

queritor · February 8th, 2007, 07:19 PM

Quote:

Originally Posted by Chuck S

Did you make the change I noted in post 6

to image-inc.php I think you forgot that

Yes, I did that first, but it didn't make any difference to the moderated ads. The last paragraph in my previous post references that.

I made your edits to image-inc.php and adm-misc.php. The link was fixed, but the email still states that the ad was submitted by the recipient of the email.

So I made the additional modification to adm-misc.php to make sure the userid of the ad was used in the get_userinfo() call and the username assigned to $tusername which is referenced in the language file.

Please let me know if there is a better way to fix this bug.

Chuck S · February 8th, 2007, 08:01 PM

Category Unsubscribe Link Broken

My post here has the correct code for adm-misc.php

queritor · February 8th, 2007, 09:17 PM

Quote:

Originally Posted by Chuck S

Category Unsubscribe Link Broken

My post here has the correct code for adm-misc.php

Ah.. OK. It looks I missed the $notifyuser bit. That's the trouble with these scrolling code boxes. You can't see the entire thing all at once and when you paste it into a text editor, you lose the bold.

Anyway, it looks like my change would have effectively been the same so all is good.

Thanks.

Chuck S · February 9th, 2007, 07:00 AM

Not a problem buddy