Value of Sold items keeps dropping(FIXED)

rastacat · October 16th, 2005, 12:46 PM

Since upgrading to 2.42 my classifieds have dropped almost $1 million in total sold items.

It appears to be working when I put an item for sale and mark it sold but something is dropping the numbers. I understand a sold/relist will add then subtract, but at this rate it won't be long until all our previous sales totals will be down to zero.

Is anyone else experiencing this?

Al

rastacat · October 17th, 2005, 05:35 PM

just to update. getting some errors like this via email:
related?

An error was encountered during execution of the query:

UPDATE pc_stats SET amt_sold=(amt_sold-), ads_sold=(ads_sold-1) WHERE id=1

The query returned with an errorcode of:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '), ads_sold=(ads_sold-1) WHERE id=1' at line 1

Chuck S · October 17th, 2005, 06:07 PM

There is only one place this query is at and then is when someone edits there ad as in relists or sells it.

If people are relisting or hitting sold back and forth you numbers will go up and down.

I suggest if it is of concern you turn off a users ability to edit there ad

rastacat · October 17th, 2005, 06:50 PM

Thanks for the response. If they hit sell/relist the numbers will change but should it not keep the correct totals even if they do?

I believe this last gent said it would not relist his ad and it did in fact expire after he followed the email instructions.

Turning off the ability for users to relist their ad doesn't sound like the solution though, if that's what you are suggesting.

Al

Chuck S · October 17th, 2005, 07:11 PM

Well I can relist and mark ads sold in my install so I am showing it works fine.

If he says it does relist for him you would need to try it and see if you get an error or something. I can't say anything more without something to go on here

If someone hits relist then values are subtracted as they should be since the email is only sent for auctions where sendnotice expires the auction and adds the amount so its a tit for tat function here. We add it and they can relist and subtract it.

Now for regular ads it is totally done by the user. If they mark it sold the amount is added. If they the relist it the amount is subtracted

So in every case I see it is tit for tat.

rastacat · October 17th, 2005, 08:43 PM

Thanks again.

Just to clarify, I'm not using the auction feature, just the classifieds function.

I see what you mean about relisting a closed auction, the price would have already been tallied up so a relist would remove it. Being a classified ad though, it was never actually sold before they click the emailed "relist" link.

I'll try and get more info on this.

Al

Chuck S · October 17th, 2005, 08:56 PM

Yes for a regular ad the user has SOLD OR RELIST

Thus which every it is the user is given the correct link when viewing there ad. If they marked it sold at which time the value is listed in the stats and they click relist it is then subtracted

As stated it is tit for tat.

rastacat · October 18th, 2005, 12:22 AM

Well, no more error messages coming in but the totals have still been dropping all night long. Looks like something is long on tats and short on tits.

dontom · October 25th, 2005, 06:51 AM

I have the same problem: Value of all sold articles is negative

So my guess is it might be a bug
Thomas

Chuck S · October 25th, 2005, 08:50 AM

The stats table is only updated in 3 places and I do not see any bug here

sendnotice.php when an auction ends which is the cron script you run.

editproduct.php to add when sold is pushed and to subtract when relist is pushed.

rastacat · October 25th, 2005, 11:23 AM

To update from my end.
We are now down $1.6 million since upgrading. The numbers keep going down every day. I turned off the days to display Sold in a guess that perhaps they kept returning to delete them and deduct, but no difference.

The number of items sold keeps dropping as well, which, I guess makes sense if it's subtracting the sales. From hundreds of items sold to below 100 now. I watched it drop 2 items from the total sold in the past hour. It should never count DOWN the number of items sold, right?

I've tried to find the specific items that matched the price drops but my "expired que" has hundreds of items and they all display whatever the current date is.

Unmodified install, no hacks added. Will be patient and see if anyone else has this problem. I can't believe it's only me.

Chuck S · October 25th, 2005, 11:29 AM

There is only one query which subtracts and rightfully so that is RESELL and resell is only displayed if SOLD was been clicked which means status is above 0 and SOLD increases your ad stats. So RESELL does this.

$query = "UPDATE {$Globals['pp_db_prefix']}stats SET amt_sold=(amt_sold-$price), ads_sold=(ads_sold-1) WHERE id=1";
$resultc = ppmysql_query($query,$link);

I have looked as stated up down and sideways and I see no bug. If you hit SOLD the amount is added and if you hit RESELL the amount is subtracted

dontom · October 25th, 2005, 01:03 PM

but something must be causing it - I have the same issue here too

Chuck S · October 25th, 2005, 01:23 PM

Well I will continue to do testing but I have looked at the code everywhich way and see no issue.

Hitting relist is the only way it can be subtracted which means sold was already hit and it was added.

I have added multiple ads to my install and hit sold and relist and additions and subtractions are performed as expected

rastacat · October 26th, 2005, 10:24 AM

Thanks for not giving up on us Chuck.
Since yesterday my classifieds dropped another 13 off the total sold and on another site I have, (not near as busy) the total sold has now gone negative. showing -1

I've done a lot of testing and found that if I post a Wanted Ad, there is the option listed of "Sold it", which if clicked, subtracts -1 from the total items sold. Relisting it, brings the number back up one, if you do not relist and delete instead, the number stays down one. This could explain the dropping number of "items sold". Seems to me it used to say "Found it" on previous versions, instead of Sold it.

This doesn't change the amounts though, something else is messing with that, but at least it's something.

Al

Chuck S · October 26th, 2005, 10:49 AM

Well your wanted ad just doesnt have a price to add or subtract thats all

As noted the only way an amount can be subtracted is to hit RELIST

However for RELIST to be shown SOLD has to have been clicked which sets status higher than 0

Thus SOLD adds and RELIST subtracts which is the tit for tat I spoke of.

In all my testing thus far everything works as expected. I have posted under several dummy acounts on my test install different ads with different prices and hit sold and relist many times and checked and the stats show correctly

dontom · November 12th, 2005, 07:15 AM

My market now shows -11 items sold.

several hundred items have been sold before, but the value keeps on dropping and dropping
http://www.mtb-news.de/bikemarkt/

Chuck S · November 12th, 2005, 07:58 AM

There is nothing wrong with the program queries

. I think I know what the issue is.

You have pages spidered in google and such

Try this in editproduct.php

Code:

Content visible to verified customers only.

and this

Code:

Content visible to verified customers only.

dontom · November 12th, 2005, 08:24 AM

Ok Chuck, the queries seem to be ok

will you put this into the next updates too?
thanks
Thomas

Chuck S · November 12th, 2005, 08:27 AM

Well what gets put into the update is Michael's call but this is safe enough to do just makes sure spider's cant trigger things.