Advice please.

[garybrun]

I have a modified version of classified that I am running as a photo record database (three images per record.) Users upload their images to one category and then an administrator moves the record to the most suitable category (there are lots.) Using Classified in this way has produced a bug which I can’t seem to fix. If a user uploads two images with the same name to the same category, the second image is refused and a warning message about duplicate images is displayed (No problem there.) But the bug occurred if they upload an image and Admin move it into the correct category, if they then upload a second image named the same and admin also move it into the same category (with the first image,) the first recorded images are over writen and the database entry becomes corrupted.

This is my understanding on how this works.
Each image is renamed with the user-number added to the front of the image name (e.g. user 666 uploads image.jpg that is renamed 666image.jpg.) These files are stored in a directory named by the category-number within the data directory. When you move a record from one category to another, the images are moved from one category directory to another… overwriting any files with the same file name.

I need to fix this and can see two avenues to pursue.
1) Each image needs to be uploaded with a unique name, perhaps utilising the date Function time(). So the image.jpg uploaded by user 666 would be renamed 666958950466image.jpg.
I would have thought this would’ve been quite easy to achieve, but three hours in, I am loosing too much hair to keep trying.
2) So how about utilising a function already available? When a record is moved from one category to another, a check is done for existing files named the same, before the move is implemented. Here is the function move_image() in the pp-inc.php.

Content visible to verified customers only.

In uploadproduct.php this script handles the duplicate image check;

Content visible to verified customers only.

Is it possible to adjust the first script to check for existing files before overwriting them?

Please could you advise which avenue I should pursue and if anyone has already fixed this please advice.

[Chuck S]

Well the uploadpage properly renames an image.

The uploadproduct renames images so you would never have an image of the same name uploaded as the file is renamed on upload so why would the move image function need to be modified?

If I am following here

[garybrun]

Maybe this has changed on the later versions of classified... I will upgrade my instalation and see if it has.

[Chuck S]

No problem I am just trying to understand why if on uploadproduct the image is renamed

02image.jpg

would become

02image1.jpg

why you would ever have an issue with moving the files and it overwriting other files

[garybrun]

On my installation this is what is happening.

We only allow users to upload to one category called “Records awaiting validation.”
Admin then moves these records to the most apt category e.g. “Ford cars models 1980 to 1985.”

We had a problem with a user who always calls his image the same “scan.jpg.”
The first record was uploaded to the “Records awaiting validation” category and then after admin checked for errors moved it to the “Ford cars models 1980 to 1985” category. The image files were named 61scan.jpg, 61scan-thumb.jpg and 61scan-large.jpg.

A week later the same user uploaded a new record with the same image named “scan.jpg” to the “Records awaiting validation” category. There wasn't a problem with duplicate images as the previous record had been moved, so the files generated were files named 61scan.jpg, 61scan-thumb.jpg and 61scan-large.jpg.
When the new record was moved to the “Ford cars models 1980 to 1985” category (after admin had validated it,) its images over wrote the previous images that were named the same.

[Chuck S]

Well there is the issue then

In uploadproduct.php remove the code in bold for this line

$querya = "SELECT id FROM {$Globals['pp_db_prefix']}products WHERE userid={$User['userid']} AND cat=$category AND bigimage='$irealname'";

[garybrun]

That's great and it works brilliantly!!! A lot better solution than what I was trying
Thanks omegatron