2.41: can not delete usergroups(FIXED)

[snoopy5]

Hi

Classifieds 2.41

I just tried to add some new usergroups. Strangeley, when I click on "(Add a New Usergroup)", I get a blank screen. When I click on "usergroups" again, the new group (Default) is there.

When I try to delete that new group, I get the alert: "You can't delete this usergroup."

What could be the reason for this?

Thanks in advance

P.S.: This was a fresh install ca. 3 weeks ago, internal registration. In case files changed inbetween and these new changes are in the download file in the member area of today, please inform me, so that I can download it and overwrite first my files with it.

[Chuck S]

I show this

if ($Globals['vbversion'] == "sellerspost") {
if ($usergroupid < 6) {
diewell("You can't delete this usergroup.");
}
}
else {
if ($usergroupid < 5) {
diewell("You can't delete this usergroup.");
}
}

If the groupid is less than 6 you cant delete it. whats the groupid on the delete link?

[Chuck S]

TRY THIS add in bold

typecast( $_REQUEST, array('usergroupid' => INT, 'admact' => STRING, 'product' => INT, 'cat' => STRING, 'ppaction' => STRING,

then in adm-misc.php find this

Content visible to verified customers only.

change to this

Content visible to verified customers only.

[snoopy5]

Originally Posted by omegatron

TRY THIS add in bold

typecast( $_REQUEST, array('usergroupid' => INT, 'do' => STRING, 'usergroup' => INT, 'admact' => STRING, 'product' => INT, 'cat' => STRING, 'ppaction' => STRING,

Hi,

I guess this has to be added in adm-misc.php too?

I did both changes in adm-misc.php, but no progress. Same behaviour as before...

[Chuck S]

That is the valid fix and I have tested it

There are two edits to make and you did them both?

I cant attach the file its too large

[snoopy5]

Hi

sorry, this still does not work. I even now downloadd again the zip file from the member area. I unzipped it and I overwrote all existing files (excepz config.php of course) to make sure that I have reall the very latest download.

On the zip file there is still the date stamp of "Pro, v2.41 (7/11/05 11:40 AM Build)"

But the files have been modified all on August 22nd and the install.php file and showmembers file today at 9am. At least that are the dates I can see after I donoded it a few minutes ago and unpacked it.

But even with this overwritinga nd changing the code in bothe places within admin-misc.php, no progress for this problem.

But if it works on your installation, I do not understand it.

So either you have an even newer files than I do, or it has something to do with my standalone (not with vbulletin integrated) installation...

[Chuck S]

Is the adm-misc.php code as I have it here in post 3?

After you sort it you can email me login details and ftp to take a look at the usergroup issue

[snoopy5]

update:

I made now a totally fresh install with the zip file of the member area of today. New database etc.. Internal registration.

Still the same problem...

[snoopy5]

uuuups, overlapping postings...

my admin-misc.php has the following erlevant parts (the newest downloads, after inserting your code):

--------------

typecast( $_REQUEST, array('usergroupid' => INT, 'admact' => STRING, 'product' => INT, 'cat' => STRING, 'ppaction' => STRING,
'sort' => INT, 'sl' => STRING, 's' => STRING, 'si' => STRING, 'cat' => STRING, 'page' => INT, 'ppuser' => INT,
'perpage' => INT, 'defdel' => INT, 'defapp' => INT, 'defhol' => INT, 'pid' => INT, 'origcat' => INT,
'catmove' => INT, 'okay' => STRING, 'fixthumbs' => STRING, 'allthumbs' => STRING, 'allmedium' => STRING,
'watermark' => STRING, 'counts' => STRING, 'scanexif' => STRING, 'start' => INT, 'updateowner' => STRING,
'cleanup' => STRING, 'category' => STRING, 'template' => STRING, 'final' => STRING, 'body' => STRING,
'stylesheet' => STRING, 'section' => INT, 'thecount' => INT, 'do' => STRING, 'approve' => STRING,
'remove' => INT, 'clear' => STRING, 'table' => STRING, 'whichfile' => STRING,
'catid' => INT) );
typecast( $_POST, array('submit' => STRING) );

-----------------


and lower in that file the other place where I changed the stuff:

---------------

if ($do == "add") {
$query = "INSERT INTO {$Globals['pp_db_prefix']}usergroups (groupid,groupname,uploads) values(NULL,'Default','0')";
$resulta = ppmysql_query($query,$link);

forward("adm-misc.php?ppaction=usergroups");
exit;
}

if ($do == "delete") {
if ($Globals['vbversion'] == "sellerspost") {
if ($usergroupid < 6) {
diewell("You can't delete this usergroup.");
}
}


if (empty($okay)) $okay="no";

if ($okay != "yes") {
adminheader( 0, "PhotoPost Classifieds User Groups" );

--------------


I copied in this posting more lines by purpose, so that you can check whether something before or after is missing...

[Chuck S]

Looks fine to me and I dont see a darn thing wrong with the code. I would need to see your install

[snoopy5]

You can't delete this usergroup.

[Chuck S]

Your linking an old thread. I asked for a url to your install and signin to see the issue

[snoopy5]

I sent you an e-mail...

[Chuck S]

Okay the build will be updated but the fixes are post 3 post 4 and this on adm-misc.php line 2978 groupid becomes usergroupid

href=\"{$Globals['maindir']}/adm-misc.php?admact=usergroups&amp;ppaction=usergroups&amp;usergroupid =$uggroupid&amp;do=delete&amp;usergroup=$uggroupname\">delete</a>)";

[snoopy5]

Thanks, that did the trick...