Cannot upload duplicate image with the same filename(NOT A BUG)

[Chuck S]

As stated there is nothing in our code that can delete your vbulletin forums. There are many users who use Classifieds and VBulletin. I even have a copy myself running on my server.

Only thing I can suggest is your upload a clean unhacked files to your server and test. You can delete everything in your classifieds directory except the data directory and config files and then upload clean files.

If you have hacks installed on your Vbulletin forum look to see they are not causing an issue

Best bet you can do is probally install a clean VB test forum and a clean classifieds test and you will see things work fine.

Your issue has to be in either hacked vbulletin or classifieds files

[Mikan]

I do have a couple of hacks in VB but I haven't hacked it for a long time and like I said I didn't have any problems before I upgraded Classifieds from 2.2 to 2.40 / 2.41. I just checked uploadproduct.php and noticed that you have changed that script a lot after 2.2 so if we play probability games do you thing it's just pure coincidence that I started to have these problems after I upgraded?

[Chuck S]

I have given you suggestions to try since you refuse our help.

This is not an issue that I can see from our software. There is nothing that can delete your forum at all in our code. There is no reference to your forum in our code other than the use of the forum header or url to it. There is no reference in any part of upload process to vbulletin. Nor can we replicate this issue and believe me we have tried. There are many sites that run Photopost classifieds 2.41 with VBulletin. You dont see any of them posting here saying there forum has been deleted. This thread began with a user complaining he could not upload a file with the same name which is the proper coding of the app as I informed him. You then come in claiming our application is deleting your forum.

I had suggested you install clean versions on a test site of VB and classifieds to confirm that what I am saying is indeed the truth. Our application does not delete the vb forum. You have repeatly refused our attempts to help. What more can I say.

[Mikan]

I think I found at least one bug that's probably causing this.

Check image-inc.php - line 45

@rename($filein, $newfilepath);

That $filein variable is empty so rename renames that file incorrectly - in my case for some reason /forums.

There's no $filein defined anywhere:
(I don't believe bulkupload is used when editing a picture)

Content visible to verified customers only.

[Mikan]

Fix:

@rename($newfile, $newfilepath);


Omegatron - what do you say now?

[Mikan]

Originally Posted by omegatron

$filein is a file not a directory.
[/code]

If you grep like I did filein-variable is not defined anywhere so it has to be empty. It can't be a file nor directory. It's nothing in your code (it should be a file of course).

If you use original 2.41 image-inc.php what do you get if you try this

if ( !file_exists($newfilepath) ) {

echo $filein; exit;

@rename($filein, $newfilepath);
$realname = $newfile;

I would say that probably nothing so unless you change you code again so that filein has a value you still have a bug (or change that to $newfile like I did).

Or how is it possible that rename works if source filename doesn't exist - since renaming usually requires a source (and a destination)?

[Chuck S]

Using the orginal 2.41 code my files get renamed and copied fine. regardless of whether it is empty or not.

The replaced function I posted is what is used in Photopost and Reviewpost so that will work.

Regardless here with you reporting this bug it would not delete your forums.

[Mikan]

Originally Posted by omegatron

Regardless here with you reporting this bug it would not delete your forums.

How is it possible then that when I used my fix I don't have that problem anymore?

[Chuck S]

what I am saying is this as I have already stated.

Is $filein is empty or not being set the worst that can happen is the file is not copied

[Mikan]

.. rethinking...

[Chuck S]

$filein is clearly defined in bulkupload.php which calls handleupload function

$filein = "$inpath/$realname";