Editing an ad removes ad enhancements

[Rich Z]

OK, now this is going to get anyone PAYING for these options pretty irritated at me. I just noticed that if I edit my test ads, when I submit the changes and then go back to look at the ads, all of the enhancments (highlight, bold, italics) are now GONE! This is both on my classifieds tied to one of my vBulletin message boards as well as a recent standalone site. All are on the latest version of PP_Classifieds.

The only thing I can think of that I change that might be significant was to comment out the code that disallows HTML code within the ads. Since I don't see anyone else complaining about this problem, does that line also have something to do with the visual enhancements of the ads?

[Rich Z]

Any reason WHY this has not been responded to? NOW I have a user who has paid for two enhancements that vanished when he went back to edit the ad.

Rich,
I just made me fisrt post on the new classified ads and paid for it to be highlighted and bold. I had to make a edit after I posted it was all good prior to that but now the format ois normal like unpaid ads.
Thanks
Xavier

http://www.faunaclassifieds.com/pp_c...&cat=28&page=1

Now what the heck do I do? Is there anyway for me to manually enable these options or do I just have to refund the guy's money? This is going to just KILL my using this system if this doesn't work flawlessly. Am I going to have to roll back to using the native vBulletin forum based classified ads because of this flaw?

I REALLY need this problem fixed! I thought the HTML enabling hack was causing this problem, so I disabled it on my site (removed it from both editproduct.php and uploadproduct.php. But it is STILL apparently there, but not at every instance.

[Chuck S]

We would need to work with unhacked files for us at support to assist you. We can not support or assist on a site that has been hacked as more than likely the issue would be the hack causing this issue

I would first ensure you have the proper template files in place. When a user edits there ad there should be a section for bold highlight and the ones the user has paid for are checked. If your edit an add and you do not see these checkbox's then your not working with a current template and means you need to upload a current template

[Rich Z]

Chuck, you did the install for me, remember? Both the original install and the later upgrade. There were NO hacks done to the edit or upload sections beyond the simple commenting out of the fixmessage(desc) command to allow html coding in the ads. That has since been removed anyway, except that I do not show the . If that current template is not in place then I suggest that it was not put there during the install.

I created a test ad in FaunaClassifieds.com (http://www.faunaclassifieds.com/pp_c...&cat=59&page=1) and when I edit it it DOES show up those checkboxes. However other older ads I created do not. I also have set up a test ad on GunWantAds.com (http://www.gunwantads.com/showproduc...&cat=29&page=1) which allows me to edit it as well and has those checkboxes visible, yet OTHER ads I placed do not have them visible.

If the enhancements are PAID options, do they show up in the edit screen then? That's about the only difference I can see as I have the test section set up for free enhancements yet the other sections charge for those options. And I do have a bonafide example listed in my previous post where a member posted an ad, PAID for two enhancements, yet had them vanish when he later edited his post.

Am I the ONLY one using paid enhancements with this program?


Where do I find this file, or would you please be so kind as to fix this problem for me?

[Rich Z]

AHA! On a whim, I set my test category on GunWantAds where the enhancements for bold, highlighted, and italics are now paid options. They DO NOT SHOW UP in the edit screen! Further, when you finish editing the ad, now that this category has those options set as PAID, THOSE OPTIONS DISAPPEAR in that ad!

I think this is a bug. Could someone verify this? I do not believe that the templates were modified in any way to cause this problem.

[Chuck S]

The only thing that would make sense is if you modified files to allow html in ads and used older files and not the new ones.

The only ads this will show on is ones where its being used. I cant verify this on my install

[Rich Z]

Well try this on your test site. Create an ad in a category that offers free enhancements (bold, highlight, italics). In your ad enable those enhancements. You will be able to see those enhancements visible when you view the category, which should be the case. Editing the ad will display those checkboxes you mentioned, and when finished, the ad will still have those enhancements intact. All well and good so far.

Now, go into your admin section and make those enhancements PAID. Just charge $1 for each of them. Then go back to your ad and edit it, now that the category it is in REQUIRES payment for those same enhancements that were for free when you originally created the ad. In BOTH of my systems, when I do that, then those checkboxes for the enhancements are NO LONGER visible. Further, when I edit the ad and then go back to view the category, those enhancements have been removed.

It has everything to do with the enhancements having charges applied in the category set up via the admin page. When someone creates an ad on my systems in a category where the enhancements are a paid option, the ad shows up fine when they complete it. However, when they go back to edit that same ad, those checkboxes are NOT present on the edit screen, and when this person finishes the edit, those options he paid for are now no longer there.

[Rich Z]

Originally Posted by omegatron

The only thing that would make sense is if you modified files to allow html in ads and used older files and not the new ones.

The only ads this will show on is ones where its being used. I cant verify this on my install

Oh, and to address this issue, my SOP is that whenever I am going to edit a file, I FIRST copy it from the server onto my local system before editing (putting a copy into a backup directory as well) and then when I finish the edit, copy it up to my server.

I got into this habit LONG ago when doing work with other developers on files that resided on a server.

So in short, no I don't believe I used an older file.

[Rich Z]

I've been doing more testing and am pretty much convinced there is a bug in the program having to do with Category Ad Price Info values of highlighting, bold, or italics being > $0.00. If the values of these (I did not test them individually) are $0.00, then I can edit the ad at will, turning these values on or off, and the ad will reflect those changes. However, if these enhancements are set where the user is charged a fee to utilize them, he can set them up when he initially creates the ad fine, with no problems. However, when he goes to EDIT that ad, not only are those click options not available to him, but no matter what changes he makes to that ad, when it is submitted, ALL of those paid ad enhancements will be gone with NO WAY at all to bring them back. Worse yet, there doesn't appear to be anyway at all for me, as the administrator to bring them back unless I temporarily set that category so those options are free, reset those click boxes, then change the category back to the paid values. Pretty clunky way to do that, I do believe. I think the admin should be able to do this AT WILL when editing any ad in the system. As it stands now, I have to either do a switcheroo as mentioned above, or else have two PayPal accounts and pay myself from one to the other in order to enhance any of my own ads I place on my own system.

But regardless, I DO need this problem fixed with the edits wiping out those ad enhancements. This could get to be a real nightmare if this classifieds system starts being heavily used and I had a bevy of irate users beating up on me because I took their money and didn't give them what they had paid for. I already have over 900 ads posted there (in my FaunaClassifieds.com site) and it is climbing every day.

Of course, the question I have now is, am I the ONLY one who is experiencing this problem? Surely other people out there are charging a small fee for those ad enhancements, aren't they? Or do you just have editing turned off for your users? That would be a solution, but I believe my users would burn me at the stake if I did that. No, that really is not an option for my system.

[djroketboy]

I can confirm this is a bug, it happens on my board as well, and my board is clean 'cept for a making "place an add" bold and yellow...

[Michael P]

I'll run some tests today and post back when I've verified either way.

[Michael P]

Okay, you are correct; if a user has paid for this option and they EDIT their ad, then the options are removed. This can be fixed by changing lines in editproduct.tmpl:

line 189:

if ( ($User['highlight'] == 1 && $adhigh == 0) || $highcheck ) {

line 199:

if ( ($User['bold'] == 1 && $adbold == 0) || $boldcheck ) {

and line 209:

if ( ($User['italic'] == 1 && $adital == 0) || $italiccheck ) {

However, if a user unchecks an options and saves it; they won't be able to turn it back on later. So, the questions is - do we try to protect users from themselves by making the options read only if they paid for them (i.e. not allow them to change them) or do we allow them to deselect an option after they've paid for it?

[Rich Z]

I vote for removing the rubber baby buggy bumpers. If someone unchecks the checkmarks then tough luck for them. There may be a valid reason that someone WANTS to remove the enhancements somewhere down the road. For instance, they may want the ad to remain on the site, but simply de-emphasize it.

A few things I would like to see in a new upgrade, however:

(1) The ability for the admin to set those enhancements for anyone's ad.

(2) The ability for a user to ADD those enhancements (meaning PAY for them as well) to an existing add. Some people do change their minds after the fact.

(3) Add a paid enhancement to either 'bump' the add to the top, or 'sticky' it to the top of the page. People will DEFINITELY pay for these options on a busy classified site.

A few days ago I have a member email me complaining that they accidentally deleted their ad. He said that he didn't realize that clicking the checkmark for "delete" then clicking the submit button would delete his ad. Duh!

Anyway, thanks for fixing this problem. I have tested it on my site and it seems to work exactly as it is supposed to now.

[rbl]

Originally Posted by Michael P

Okay, you are correct; if a user has paid for this option and they EDIT their ad, then the options are removed. This can be fixed by changing lines in editproduct.tmpl:

line 189:

if ( ($User['highlight'] == 1 && $adhigh == 0) || $highcheck ) {

line 199:

if ( ($User['bold'] == 1 && $adbold == 0) || $boldcheck ) {

and line 209:

if ( ($User['italic'] == 1 && $adital == 0) || $italiccheck ) {

My guessing powers are low this week. Changing the lines how Michael? =)

[Chuck S]

Thats already in our download.

Now I posted this the other day something that solves this although I think in the update for 2.5 it is best to only show these for admins or mods as it allows anyone to edit there ad and add these enhancements as they see fit without paying for em.

In editproduct.php add in bold

'origcat' => INT, 'category' => INT, 'edit' => STRING, 'delete' => STRING, 'myzipcode' => INT, 'price' => STRING, 'highlight' => INT, 'bold' => INT, 'italic' => INT));

[rbl]

If that is already in the download, why doesn't that fix the odd bug of editing the ad -> losing bold/italic/highlight?

[Chuck S]

what you posted on is in the download what I posted isnt but does fix it

[rbl]

Oh ok, I was mislead by Michael's words "This can be fixed by changing lines in editproduct.tmpl"