customfields_entries not deleted when image is deleted

antivirus · May 16th, 2010, 12:11 PM

vbgallery version 2.5

When deleting any image that has custom fields, the corresponding entry in tha ppgal_customfields_entries table is not deleted.

This happens on both methods for deleting an image:

on showimage.php - FileTools > Delete This File > Perform Action
on editimage.php - Delete This File > Delete

Not fixing this bug results in many unnecessary "dead" entries in the ppgal_customfields_entries table

Luciano · May 18th, 2010, 03:26 PM

good find...
this comes from the fact that hardly anyone uses the customfields...

to fix open forum/includes/functions_gallery.php
find

Code:

Content visible to verified customers only.

below add:

Code:

Content visible to verified customers only.

(imgid is not a typo.. its not imageid but imgid)

That should fix the problem.
(couldnt test it.. as i dont have vb 3.8 installed anymore)
-------------
Now the problem that persists is what to do with the leftovers.

this depends on how many images you have..

you can do it the hard way..
open any file.. showimage is a good example

after

Code:

Content visible to verified customers only.

add

Code:

Content visible to verified customers only.

Now check the highest imageid you have... (go to phpmyadmin and sort table ppgal_images by imageid)

if its smaller than 30000, run the page, remove the code you added on showimage (for example) and you are done.

but if its higher, for example 65123

then you have to run the page 3 times.. changing $startimage 3 times
run it once as it is...
then open file change $startimage = 0; to startimage = 30000;
run the file again...
then open file change $startimage = 30000; to startimage = 60000;
run the file again...
then open file change $startimage = 60000; to startimage = 90000;
run it again...
basically you move up by 30000, until your highest imageid is included in the nummer..

You are done.. remove what you have added in showimage or whereever..

Luc

PS: i chose 30000 because i know that with around 50.000 depending on your mysql settings you can run into memory problems..

antivirus · May 25th, 2010, 10:24 AM

Sounds good Luciano, thanks!