Problems with banned user..

[Luciano]

Sorry chuck if i seem to find lots of little ones.. but i'm going through the files line by line and testing all eventualities.. the site has to be finished by feb. 1st.

I have a user called tester.
I banned that user.. to see what output he gets in gallery..
If he is in gallery (showimage).. he gets the u are banned page..
BUT the replacements are NOT made...
so he gets-> javascript error.. AND no css.. which looks horrible in vbulletin..

the replacements cant be made.. because the url of the page is still:
http://..../gallery/showimage.php?i=40&catid=5
the global thinks its showimage script...

OK if we banned the user, we dont really care what he gets for output.. but i had really trouble reading the page without any css..

Luc
PS: I did some tests and we do need the $show['avatar'] = false;

[Luciano]

Ok i seem to have fixed it..
I rewrote the whole forum/includes/vbgallery/error_generic.php

It includes now the old replacements and the new ones for banned user.
AND i added a conditional: if(PP_SCRIPT == 'vBGallery')

BUT to remove overhead.. this conditional should be in the plugin code and NOT in the file.. otherwise if an error is generated by vbulletin or other script.. then it still loads the file.. ok it doesnt do anything but still if we can avoit it.. why not.. (btw this can also be done with plugin style_fetch.php in plugin code)


so i would suggest for future versions to have this plugin text as following:

Content visible to verified customers only.

but for now.. to fix the banned user problem, do following:
open: forum/includes/vbgallery/error_generic.php
and replace ALL the content with:

Content visible to verified customers only.

ATTENTION I ONLY DID THE REPLACEMENTS I THOUGHT WERE NEEDED (I have most links in header and footer allready prefixed with $vboptions[bburl] in template.. so in my install i only needed clientscript and sendmail.php
so please check if there are any missing.

Luc