PhotoPost Photo Gallery Sales PhotoPost Sales Toll Free Phone Number
Mon-Fri 9am-4pm EST
  PhotoPost Photo Sharing Photo Gallery    Visualize community tm
| | | | | | | | |
Old December 7th, 2008, 02:53 PM   #1 (permalink)
Registered User
 
Join Date: Aug 2005
Posts: 1,229
Showimage bug with sorturl

Just stumbled into this one.. strange that no one found it before...
its a typo..
What it does..
When you have an image with more than one page of comments..
and you go to page 2 you loose the category.. (at least when you are in a special category like member or search or or or..)

AND

When you use on the fly watermark you also loose category and everything else except imageid (probably thats why some users have problems with permissions in member category when using watermark..)

... maybe more issues
-------------------------
What happens:
at 2 places the url looses the sorturl..
How?
sorturl is generated at top of showimage
with: $adv_sorturl = construct_adv_sort_url();

this is used in prev/next links.. thats ok..

but it is also used in 2 other places.. only there.. the string is not called $adv_sorturl but $adv_sort_url. But of course the $adv_sort_url is never generated.. so its ALLWAYS empty.

FIX: open showimage.php
find: $adv_sort_url (its there 2 times)
replace with: $adv_sorturl (both of them)

voila.. thats it.. I think it probably was a typo when the script was created. Nobody seen it, because when you are reading comments and are on page 2 you dont realy check if the category name is still the same than on page 1...

Luc
Luciano is offline   Reply With Quote
Old December 7th, 2008, 04:55 PM   #2 (permalink)
Photopost Developer
Verified Customer
 
Chuck S's Avatar
 
Join Date: Jun 2002
Location: Abingdon,MD
Posts: 71,683
Thanks nice catch got it
__________________
Photopost Developer and Support Engineer

Please do not PM me for support or sales questions. Thank you for your understanding.
Chuck S is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
showimage.php not working. hob Installs and Upgrade - vBulletin 3.6x 2 April 7th, 2008 05:21 PM
...showimage.php?i=17 doesn't work Haenk How Do I? - vBulletin 3.6x 0 February 25th, 2008 04:15 AM
showimage.php got hacked... Slingblade61 Installs and Upgrade - vBulletin 3.6x 12 October 12th, 2006 06:53 PM
showimage.php DementedMindz Bugs - vBulletin 3.5.X 3 September 25th, 2006 06:58 AM
ShowImage.php cgmojoco Installs and Upgrade - vBulletin 3.0.X 4 June 29th, 2005 05:26 PM


All times are GMT -5. The time now is 12:51 AM.

Powered by vBulletin® Version 3.8.1
Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0