Showimage bug with sorturl
 

Just stumbled into this one.. strange that no one found it before...
its a typo..
What it does..
When you have an image with more than one page of comments..
and you go to page 2 you loose the category.. (at least when you are in a special category like member or search or or or..)

AND

When you use on the fly watermark you also loose category and everything else except imageid (probably thats why some users have problems with permissions in member category when using watermark..)

... maybe more issues
-------------------------
What happens:
at 2 places the url looses the sorturl..
How?
sorturl is generated at top of showimage
with: $adv_sorturl = construct_adv_sort_url();

this is used in prev/next links.. thats ok..

but it is also used in 2 other places.. only there.. the string is not called $adv_sorturl but $adv_sort_url. But of course the $adv_sort_url is never generated.. so its ALLWAYS empty.

FIX: open showimage.php
find: $adv_sort_url (its there 2 times)
replace with: $adv_sorturl (both of them)

voila.. thats it.. I think it probably was a typo when the script was created. Nobody seen it, because when you are reading comments and are on page 2 you dont realy check if the category name is still the same than on page 1...

Luc

Thanks nice catch got it