Last upload image title doesn't update on index [low priority]

Luciano · December 4th, 2008, 02:05 AM

this is a low priority bug.. i stumbled into it when testing editimage on a fresh install.

Actually its not a bug.. but as vbgallery is designed (its simply missing)

to reproduce:

Look at gallery homepage or any parent category page:
You have(example) in table Last Upload:
Image title
by Luciano
12-02-2008 09:20 AM

that is correct!

But if you go to that image.. then you edit that image.. AND change the title.. the NEW TITLE is displayed correctly in showimage ..
BUT it is NOT UPDATED in the category's lastimagetitle field..

so on the mainpage you still will have the OLD title untill a new image is uploaded.

imho there should be something like this in editimage right after the update query:

Code:

Content visible to verified customers only.

Actually as no-one seen it before, its low priority and i think it would be enough if michael included it in new release..

Luc

Chuck S · December 4th, 2008, 09:55 AM

Actually possibly maybe a cache thing also but would need to look more to comment on that.

Luciano · December 4th, 2008, 05:05 PM

Well for me it didnt.. checked all cached stuff..
the problem is users usually only edit the title right after upload..
so it can happen quite often..

i'm just testing a fix.. maybe you could test it also.. because I never use category 3 level only have level 1 and 2 installed.. AND I never use member categories.
Just added a 3rd level and it works.. but who knows.

ok.. here we go:
2 changes in editimage:
first the query:
added the images.title
AND
added a left join categories.. but with lastimageid=imageid
so we only get lastimagetitle and parentlist IF image is last image...

in editimage find:

Code:

Content visible to verified customers only.

replace with:

Code:

Content visible to verified customers only.

then, a bit lower after the normal update we add our update:
find:

Code:

Content visible to verified customers only.

and above add:

Code:

Content visible to verified customers only.

thats it.

Luc

PS: we should sooner or later replace all the addslashes(htmlspecialchars($image['title'])) with $db->escape_string(htmlspecialchars_uni($image['title']))
which I think is more appropriate and vbulletin standard.

I did it on a testinstall for all title and description database operations and it works fine with many special characters...

Chuck S · December 4th, 2008, 08:09 PM

I will try it out.

Luciano · December 5th, 2008, 12:41 AM

oops...
ATTENTION: edited the code above.. (both.. code and query) it did NOT update when lastimagetitle was empty..

Chuck S · December 5th, 2008, 10:36 AM

That code works fine

Luciano · December 6th, 2008, 03:54 AM

Thanx... just seen something else

there also is a lastimagetitle ALSO in ppgal_user which is NOT updated in imageedit

so if you upload an image with blank title.. then edit title... in profile or whereever lastimagetitle is needed .. it will be empty (or the filename)

I will see if i can add this to the editimage fix..

Luc

Chuck S · December 6th, 2008, 09:59 AM

yeah not critical things here but good to fix cosmetic things. I have sent anything I have fixed to Michael for inclusion in the new beta as well as updated the current build.

Luciano · December 7th, 2008, 06:03 AM

OK Chuck, updated the code above in the post:

added a left join for table ppgal_user so the lastimageid and lastimagetitle can be fetched..

IF the lastimageid == the edited imageid AND the 2 titles are not the same.. then it also updates the ppgal_user table's lastimageititle..

---
I also added a if ($imageinfo['catid'] == $image['catid']) to the code.. because now the lastimage for the category is only done when the user did only changed the title!!!! If he also changed the category (at the same time which he can) then the work with the titles (remove from old category.. pass to new etc..) is done in the update_count function that is called below.

Luc

probably the code can be shortened.. but I think editimage is not high traffic and it is clearer like this..

Chuck S · December 7th, 2008, 08:36 AM

yeah I will see if I can clean it up.

Luciano · December 16th, 2008, 12:29 PM

Quote:

Originally Posted by Chuck S

yeah I will see if I can clean it up.

Well it works.. but.. it is more complex

if you have setup like follows:

maincat
-----subcat1
------------subcat2
-----subcat3

and you edit title in subcat 2... for image uploaded yesterday..
BUT in subcat3 someone uploaded image this morning.. then his title should appear on mainpage..
my new title should only appear on subcat 2 and subcat 1

his title should remain lasttitle for subcat3 and maincat..

But my fix will update subcat2 + subcat 1 AND maincat.. (but maincat should be left as is..)

I'm not quite shure how to do this.. without checking all last imageid in parentlist..

Luc

Chuck S · December 16th, 2008, 12:32 PM

yeah well would have to think about that one

Luciano · December 16th, 2008, 02:22 PM

well i think i found something thats easy...

instead of

Code:

Content visible to verified customers only.

just use

Code:

Content visible to verified customers only.

we just update the last image title in all cats that have the imageid as lastimageid..

I think it takes less reasources and less queries.. and should work..

Luc