little Cron bug and maybe dst ...+ [fixes]

[Luciano]

Just downloaded fresh 2.43 so i could verify the bugs are NOT self made..

there is an extra & in the cron call url.. only in gallery footer (check it in the html source code..

Content visible to verified customers only.

that gives as image src url:
cron.php?&rand=12344432

cron is called but is not cached as most servers dont like ?&

fix: find the line above in gallery_global.php
and remove the &

Also.. i logged in as a user i didnt use for a very long time.. and the daylight saving form got active.... as i logged in on a gallery page.. it redirected me to:
www.myhost.com/gallery/profile.php?do=dst
thast a page not found error..
i checked and there is no replacement for the automatic daylight saving form in footer. it should be in gallery global..

there are 2 fixes possible:
1: in vbulletin footer template add a $vboption[bburl]/ in front of the profile.php in the dst form.. (thats what i did)
or
2: add a replacement in gallery_global.php

Luc

[Chuck S]

Well that would not be the direct fix.

Your forgetting about this thing

' . $vbulletin->session->vars['sessionurl'] . '

So in essense the line should look like this

Content visible to verified customers only.

[Chuck S]

I hate vbseo remove this from that line of course

Bugs - vBulletin 3.6x - PhotoPost Community

[Chuck S]

Your replacement for profile.php can be done in admin vbgallery settings under footer replacements just like you do for any links in header navbar

That is really a vbulletin issue since they still after all these years refuse to fix that bug in their program. So much they would solve for people if they would simply prefix their url on their program links etc in their code.

[Luciano]

concerning 1.

Originally Posted by Chuck S

Well that would not be the direct fix.

Your forgetting about this thing

' . $vbulletin->session->vars['sessionurl'] . '

Well.. the original vb cron url in vbulletins global.php is:

Content visible to verified customers only.

so there is a sessionurl (allthough i dont know what its for)... and they use TIMENOW instead of vbrand(1, 1000000) wich is less ressource intensive (though i think thats minimal)
other thought: what about that complicated function create_full_url ??

concerning 2. yes you are right.. replacement for profile.php in footer works fine...

Luc

[Chuck S]

$vbulletin->options['bburl']

That should do the same as create full url it just places the vb url on front of the script name.

well granted they may have this in there but it is never full

' . $vbulletin->session->vars['sessionurl'] . '

If it was you would have another issue because you must use a & tag between variables in a url.

Since the cron runs without user interaction what I posted should work fine. You just need to remove the link to this forum in the code which is why I hate vbseo.

[Luciano]

yes sou are right.. ... $vbulletin->options['bburl'] should be the same..
as to $vbulletin->session->vars['sessionurl']

i looked into it some time ago .. because in my office the browsers are set not to accept cookies

its only full in that case.. IF cookies are accepted by the browser, then the sessionurl is in the cookies.

BUT no there does not need to be a & sign there..

when full.. $vbulletin->session->vars['sessionurl'] gives
s=5345jlkjedlj54353445u09&

you also have $vbulletin->session->vars['sessionurl_q'] that gives:
?s=5345jlkjedlj54353445u09

the $vbulletin->session->vars['sessionurl_js'] is the same as $vbulletin->session->vars['sessionurl'] but instead of & it only has a & at the end..

actually i only found out about the difference because I ran into the problem and always got logged out when changing pages.

The only reason I see that session url could be there is preventing users to get logged out when their cookies are not enabled..

Because gallery page is called.. with sessionurl from another page..
it is processed.. sessionurl is ok.. so users stays logged in..

when processed page is displayed in browser, the hidden cron image is called..
no sessionurl.. ==> user gets logged out if he doesnt continue surfing within the session timeout.
He only sees he is logged out when he refreshes page.. or moves to another page.

thats why i think the $vbulletin->session->vars['sessionurl'] should be there .. whithout the &


Luc

If i remember correctly there was an attempt to fix all sessionurls in templates AND code long long time ago.. (brian had inverted some sessionurl and sessionurl_q) .. but i think zach had missed one or two.. because i still get logged out when I surf from the office.. i will run some tests when back from holiday and let you know which ones are errored)

[Chuck S]

I would get a headache keeping all that straight but seems like you remember alot of stuff there.

[Luciano]

Originally Posted by Chuck S

I would get a headache keeping all that straight but seems like you remember alot of stuff there.

http://www.vbulletin.com/forum/showthread.php?t=221107


thats because I'm old ...

i'm starting to forget again...

looooooool

luc

[Chuck S]

LOL I am old too but I dont really participate on vbulletin.com etc so yeah I would not know that one