[Editimage] Searching Bug confirmation.. and fix

[Luciano]

I stumbled into a little bug.. in edit image when replacing an image..
Now it could be my install because i did some modifications in the functions_gallery_imageedit.php.

On the other hand.. the fix is not there.. but in edit_image.php itself.

So if someone could check if he/she has the same bug..
If no.. then its me (and i fixed it) so its ok..
If yes.. then everybody can apply the fix.. thats ok also
-----------
To reproduce the problem:
Go to an image and then in edit image.
There you have the possibility to replace the image.
Replace it!
It works but it seems that the thumbnail is NOT replaced...
(actually it is.. but if you replace it twice its allways the last thumbnail that is created.
So if you replace the first image -> with second image .. I still have thumbnail of first image.
Now if I replace the second image -> with third image .. I now have thumbnail of second image with image of third..
etc.. etc...
-------------
The fix is easy:
in editimage.php
find:

Content visible to verified customers only.

just invert the order of the 2 lines:
change to:

Content visible to verified customers only.

it now works correctly with me..

I would only be curious if others have the same problem.. or if its just me

Luc

[Chuck S]

I will test that out and let you know thanks.

[Luciano]

thank you sir!

[Chuck S]

Have a good day sir

[Luciano]

btw while you are checking.. found something strange... its a half bug...
lets call it a bug that does not cause any errors because it does not affect anything... but... it still is wrong (could be fixed in future version)

the function process_upload is called twice in vbgallery... once in editimage.php and once in upload.php
its called:
function process_upload($thumbcreated = false, $new = true)
note the 2 parameters..
in edit image its called with process_upload(false,false)
and in upload it is called with process_upload(true)

the problem is.. the $thumbcreated = false parameter is a dummy !!!!!!
$thumbcreated is NOT used anywhere in vbgallery!!!

the function should therefore be:
function process_upload($new = true)

the call in upload.php would then be correct with
process_upload(true)

the call in editimage.php would have to be changed to:
process_upload(false)

(of course you can correct it the otherway round.. by changing the call of the function in upload.php from process_upload(true) to: process_upload(false,true) but i think the correct way would be as stated above)

it now works because the call in upload affects only the dummy variable and the new variable is default true.. I think though, it should be changed in a future release...

Luc

[Chuck S]

The function is fine as is.

Content visible to verified customers only.

There are two variables passed in the case of editing a photo because if you replace the photo we need to actually reprocess it. Its just an extra variable whereas in upload.php we only need to pass one variable as its a new photo period.

[Luciano]

Yes i agree.. and i agree also that the function works as is..

but i was just wondering what the $thumbcreated variable was doing there.. as it is NOT used anywhere.. As it is not used.. i thought it would LOOK nicer if it was removed.
that was all!!!
Luc

[Chuck S]

I did not originally write that variable so who knows.