[Bug 2.4.3] Plugin on fetch_userinfo_query causes DB errors

[Chuck S]

Well I will have to do some testing as the last code change posted here people could not use.

[Luciano]

Originally Posted by Kirby

It is definitly better than an additional plugin, I just wanted to make it as easy as possible for other users who do not feel comfortable touching the files ;-)

Btw: The code could be shortended down a bit more:


Avoids some ubnnecessary array_operstions (eg. explode)

You are right of course.. i left the explode because I think i remembered that Zach wanted to add some additional arrays.. for some future add-on.. but in this case it is better to remove it.. as we want to get this running...

as for the other array.. i created it to make it more readable for others.. but the best and more correct way is the way you posted it..

Luc

[Chuck S]

We are testing any posted code to see the correct solution for all cases

[Luciano]

Originally Posted by Kirby

To get an SQL error:
- Deactive vBGallery
- Create a new User via ACP
- Activate vBGallery
- View the profile of the newly created user

Well i guess the problem comes also from tha fact that the user was not inserted into the gallery user table, as the gallery was shut off.. ( this is a guess)

If you run updateuserposts every time you shut off the gallery for maintenance.. (and if you turn it on again) the poblem should only be there for the time the gallery is turned off on the profile of the user that registered..

code snippet from update user posts in gallery functions..

Content visible to verified customers only.

this updates the ppgal_user with the data from the vbull usertable..

I agree this is not a fix.. but you can resynchronize the tables by running this.. and the problem will only arise next time you turn gallery off AND a user registers during that time..

Luc

PS: These are just thoughts for finding a real fix

[Chuck S]

Originally Posted by Luciano

I agree this is not a fix.. but you can resynchronize the tables by running this.. and the problem will only arise next time you turn gallery off AND a user registers during that time..

Luc

PS: These are just thoughts for finding a real fix

But see in here lies the issue as the only fix I know of is exactly what is already in the software that you point out. if one chooses to run the plugin to update userinfo with gallery and you turn off the gallery so this cant be done then there is the option to rescan already and update after you close the gallery so if I read correctly this is the correct action and the only fix I would know of.

This is also why not many people where able to replicate the issue and it only affected a couple people.

[Luciano]

well actually i've continued thinking..
the solution would be to run a plugin somewhere when user registers complete when gallery is off..

(if gallery is off) AND (gallery user table exists) and (userid is not in gallery user table)
==> then add user to gallery table..

Luc

[Kirby]

The real solution would be a trigger - unfortunately MySQL does not yet support multiple triggers :-(

[Luciano]

very strange...
i just did a fresh install.. on localhost..
i did the fix in fetch_userinfo_query.php (the file edit one)
Attention.. in order to be able to use the profile.php?do=vbgalleryprofile you have to add the "profile" to the THIS_SCRIPT definitions..!!! (but thats only for my version of the fix)

i have 2 users..

i did what kirby said to reproduce the problem..
1. deactivated gallery
2. added new user tester via acp
3. activated gallery
4. went to profile of tester...
result => no problem...

actually the plugin i thought of above allready exists!!!...

it is called Add User to Gallery on Register
and called at hook: register_addmember_complete

content: require(DIR . '/includes/vbgallery/register_addmember_complete.php');

content of register_addmember_complete.php:

Content visible to verified customers only.

this hook is called if gallery is on or off...

so it seems I am missing something.. OR I misunderstood the problem.. because after applying the fix i cant find any problem remaining..


Luc
I'll reread the thread

[hotwheels]

So are any of these codes fixing the issues with the gallery? Where is zach? If the codes are working, i will update my site later today, thanks.

[Chuck S]

Well the only bad part of code Zach responded along time ago on and fixed. There are no open issues with this.

You can not turn your gallery off and run the forum alone and then turn on the gallery and expect things to work correctly without running the vb maintenance tools to sync the users that is the reason the tool is there.

We found out explicitly this is why people where having an issue.

[info5538]

What exact maintenance tools should be run? I have never disabled the gallery, but I still have the problems that are only fixed by turning off gallery pictures within a member profile.

I'm going to try the newer 8-31-2008 build. However, on a directory compare, I noticed a single quote missing from the useradmin_update_data.php file (which strangely exists in the .bak version). The current version has a line as follows

$galusers = $db->query("SHOW TABLE STATUS LIKE ". TABLE_PREFIX . "user'");

I'm no programmer, but it looks to me like that would produce an error.


Side question: For those of us that pay yearly renewals, can we expect there to be continued development?

[Chuck S]

I beleive they are looking at development soon but as far as the query that is sound.

If you have profile photo issues that does not sound like this discussion so you might want to post a new thread.

[Ramses]

This bug is still active on 2.5 beta

[jazde86]

OMG, not fixed in 2.5 Final Release - after upgrade I get SQL errors like above en masse.

[Chuck S]

This would be incorrect from what I see to say this has not been changed in 2.5. The plugin which is location useradmin_update_save definately has the proper query.

[jazde86]

I've to disable the Userinfo merge plugin which is location fetch_userinfo_query to not get errors by register a new user.

The code is

$hook_fields = array(
"ppgal_user.*",
);

$hook_joins = array(
"LEFT JOIN " . TABLE_PREFIX . "ppgal_user AS ppgal_user ON (ppgal_user.userid = user.userid)",
);

$hook_query_fields .= ', ' . implode(', ', $hook_fields);
$hook_query_joins .= "\r\n" . implode("\r\n", $hook_joins);

[Chuck S]

Right but what specifically is your error? The issue talked about in this thread was definately resolved and is the plugin I talked about

[jazde86]

First:

Invalid SQL:
SELECT location, badlocation FROM pre_session WHERE userid = AND lastactivity > 1244668753 ORDER BY lastactivity DESC LIMIT 1;

MySQL-Fehler : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND lastactivity > 1244668753 ORDER BY lastactivity DESC LIMIT 1' at line 1
Fehler-Nr. : 1064
Fehler-Zeit : Wednesday, 10.06.2009 @ 23:29:13
Datum : Wednesday, 10.06.2009 @ 23:29:13
Skript : .../member.php?u=xxxx
Referrer :
IP-Adresse :
Benutzername :
Klassenname : vB_Database
MySQL-Version : 5.0.77-community

Second:

Invalid SQL:

SELECT * FROM pre_search AS search
WHERE searchhash = 'ba8f07155aa61796fc30106c302de4c0'
AND userid =
AND completed = 1;

MySQL-Fehler : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND completed = 1' at line 4
Fehler-Nr. : 1064
Fehler-Zeit : Wednesday, 10.06.2009 @ 21:07:46
Datum : Wednesday, 10.06.2009 @ 21:07:46
Skript : .../search.php?do=process

Third:

Invalid SQL:

SELECT MAX(dateline) AS lastpost, COUNT(*) AS total
FROM trillian_usernote AS usernote
WHERE userid =;

MySQL-Fehler : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3
Fehler-Nr. : 1064
Fehler-Zeit : Wednesday, 10.06.2009 @ 21:21:32
Datum : Wednesday, 10.06.2009 @ 21:21:32
Skript : .../member.php?u=xxxx

[Chuck S]

None of those queries specifically note anything about vbgallery or the plugins.

You can always use the vbgallery maintanance script and update userinfo to see if this assists you

This could simply be an old issue from 2.43 on old users and you need to update certain fields.

I bet if you enable the plugin you meantion and register a new user and view his profile you dont see issues. I am running vbgallery and see no errors like this.

[jazde86]

What I've done:

- Activate the plugin Userinfo merge again
- Running all the vBGallery maintenance scripts, every user profile is ok.
- Registering a new user (regular, not AdminCP)
- Getting SQL errors during registration, see above
- Getting SQL errors if I view the profile of the new user
- Disable the plugin Userinfo merge again
- Viewing the new user profile without any errors (no vBG maintenance done before)