[Bug 2.4.3] Plugin on fetch_userinfo_query causes DB errors

[Chuck S]

The fix noted only fixes an issue with adding a user to the gallery table on registration I do beleive you still want to disable the userinfo plugin in the gallery per the post above

http://www.photopost.com/forum/1229742-post12.html

[Kirby]

Related to this Bug:
Field user.lastpostid gets overridden as well, causing the wrong post being displayed as the last post in profile (at least).

Workaround
Add a Plugin with a high execution order on fetch_userinfo_query

Content visible to verified customers only.

In Templates adv_gallery_member_block, adv_gallery_member_stats change all occurances of lastpostid into gallastpostid.

[Mike_K]

Wow.... now I have realy an DB error.

After adding the plugin no access more. DB errors:

SELECT
userfield.*, usertextfield.*, user.*, UNIX_TIMESTAMP(passworddate) AS passworddate,
IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid,
language.phrasegroup_global AS phrasegroup_global,
language.phrasegroup_holiday AS phrasegroup_holiday,
language.phrasegroup_adv_gallery_int AS phrasegroup_adv_gallery_int,
language.options AS lang_options,
language.languagecode AS lang_code,
language.charset AS lang_charset,
language.locale AS lang_locale,
language.imagesoverride AS lang_imagesoverride,
language.dateoverride AS lang_dateoverride,
language.timeoverride AS lang_timeoverride,
language.registereddateoverride AS lang_registereddateoverride,
language.calformat1override AS lang_calformat1override,
language.calformat2override AS lang_calformat2override,
language.logdateoverride AS lang_logdateoverride,
language.decimalsep AS lang_decimalsep,
language.thousandsep AS lang_thousandsep
, user.userid AS userid, ppgal_user.lastpostid AS gallastpostid, user.lastpostid AS lastpostid
FROM user AS user
LEFT JOIN userfield AS userfield ON (user.userid = userfield.userid)
LEFT JOIN usertextfield AS usertextfield ON (usertextfield.userid = user.userid) LEFT JOIN language AS language ON (language.languageid = IF(user.languageid = 0, 2, user.languageid))

WHERE user.userid = 88;

MySQL-Fehler : Unknown column 'ppgal_user.lastpostid' in 'field list'
Fehler-Nr. : 1054
Fehler-Zeit : Wednesday, 27.08.2008 @ 12:02:24
Datum : Wednesday, 27.08.2008 @ 12:02:24
Skript : Title here!
Referrer :
IP-Adresse : 87.1xxxxxx
Benutzername :
Klassenname : vB_Database
MySQL-Version :

No access to the forum or admin-cp!

I deleted now in the DB the plugin.
Deleted also in the Datastore / pluginlist the code

s:595:"$hook_query_fields .= ", user.userid AS userid, ppgal_user.lastpostid AS gallastpostid, user.lastpostid AS lastpostid";

Now I have access to the forum, but not to the admin-cp!
Error: Warnung: array_merge() [function.array-merge]: Argument #1 is not an array in [path]/includes/init.php (Zeile 271)

In the forum, all plugins are not present.

I have run the tools.php from vbulletin. But nothing happend.

I need HELP!

[Mike_K]

Okay, restored in datastore the pluginlist and pluginlistadmin tables with a backup.
Now I am already in and also the admin-cp works.


But for me, I am waiting now for an official bugfix and I hope that something will happen in the near future!

[Kirby]

You've disabled the original Plugin on Hook fetch_userinfo_query, hence you are getting a SQL error as table ppgal_user isn't being JOINed.

Oder auf Deutsch:
Du hast das urprüngliche vBGallery Plugin auf fetch_userinfo_query gelöscht oder deaktiviert.
Dieses wird benötigt, sonst feht der JOIN auf Tabelle ppgal_user und du kriegt og. SQL error ;-)

[Mike_K]

Hello Kirby, It's right! I have had disabled the plugin Userinfo Merge.

Auf deutsch ( ): Und nun habe ich keinen Mut mehr, da noch mal beizugehen.

[Chuck S]

Please use default files downloaded here as the suggestion by a user here is not correct.

Lets discuss how you get an issue.

I have a brand new vbgallery installed with vb 3.7

http://www.reeftalk.com/vbag

You can use login testing and testing

I am not seeing any emails with query errors. I have registered 2 test users through the forum registration script and everything appears to be working and I am using the userinfo merge plugin

The only issue I show that was an issue with the plugin was this below and the downloadable code has been updated to reflect this change

http://www.photopost.com/forum/1224161-post2.html

You might want to download 2.4.3 and make sure you upload the file

/forums/includes/vbgallery/useradmin_update_data.php

[info5538]

On your test site, it appears that you have disabled the member profile options that allow vbgalley photos to appear on their profile page. Users can also set how many and what type of vbgallery photos appear on their profile (random, most viewed, laest, etc). I know that the profile options has at least one way to produce an error.

Originally Posted by Chuck S

Please use default files downloaded here as the suggestion by a user here is not correct.

Lets discuss how you get an issue.

I have a brand new vbgallery installed with vb 3.7

PhotoPost vBGallery

You can use login testing and testing

I am not seeing any emails with query errors. I have registered 2 test users through the forum registration script and everything appears to be working and I am using the userinfo merge plugin

The only issue I show that was an issue with the plugin was this below and the downloadable code has been updated to reflect this change

http://www.photopost.com/forum/1224161-post2.html

You might want to download 2.4.3 and make sure you upload the file

/forums/includes/vbgallery/useradmin_update_data.php

[Chuck S]

Please tell me where this is set. Only addons included in vbgallery are a link in navbar and photos on forumhome of vb under vbgallery addons in admincp

Is this some hack?

[info5538]

Originally Posted by Chuck S

Please tell me where this is set. Only addons included in vbgallery are a link in navbar and photos on forumhome of vb under vbgallery addons in admincp

Is this some hack?

Looks like you don't have profile customization turned on (so members can tweak colors/etc of their profiles). I believe that has to be turned on in order for users to customize their profile gallery options. I uploaded a test pic, but it requires moderation.

[Chuck S]

What I am saying is this some hack to vbgallery etc because the default vbgallery code does not show any type of photos in a member profile.

Their are two open vbgallery issues.

This one someone reported the user fetch issue and had an error on registration and the fix for this is posted in post 2 or so of this thread.

Given that issue I installed the current code with my stock non hacked vb and I find no issues.

You keep going off on in the direction of some profile thing therefore you must be discussing a hack since vbgallery does not have any supported code that shows things in the vbulletin profile.

[Kirby]

You keep going off on in the direction of some profile thing therefore you must be discussing a hack since vbgallery does not have any supported code that shows things in the vbulletin profile.

That simply isn't true :-)
vBGallery 2.4.3 by default comes with the option to show a tab and a block in member profile.
The Tab shows some statistics, while the blocks shows a photo.

Here are the Admin CP phrases for for the feature, taken from a 2.4.3 packaged I just downloaded

Content visible to verified customers only.

And the Templates

Content visible to verified customers only.

The errors posted in this thread are still there in the current package.
Workaround: [Bug 2.4.3] Plugin on fetch_userinfo_query causes DB errors

[Chuck S]

Your missing what I am saying I downloaded and installed vbgallery with vb 3.70 and I am asking where you turn that stuff on at because nowhere am I seeing turn on profile stuff anywhere.

I am not a vbgallery support tech here I am merely trying to help out and see if I can assist you all.

[info5538]

Chuck,

I'm not going off in some random direction I swear! Let's be cordial -- I appreciate your help on this. Gallery Profile pictures are part of vbgallery. They have been for a very long time. I had them in mine with no additional hacks. They only disappeared very recently when we were told to make file edits and disable a vbgallery plugin (userinfo_merge) to resolve mysql bugs/errors. I believe disabling the userinfo plugin disabled the photos in your profile feature. So it is possible the 'bug fixes' included in the very newest vbgallery have unintentionally disabled the functionality.

You can see that Zach mentioned they are included in vbgallery right in this thread (from a LONG time ago).
http://www.photopost.com/forum/vb-3-...r-profile.html

You can also see them listed as features in the CURRENT release notes here:
PhotoPost vBGallery, v2.4.3 Released!

PhotoPost vBGallery, v2.4.3 Released!
Requirements
- vBulletin 3.7.0
- PHP 4.3.3 +
- MySQL 4.0.16 +


What's New ?

* Clean Description in showimage page <title> - $image[description_clean]
* Added securitytoken to submit forms to operate in 3.7 vBulletin.
* Profile Enhancements
o User CP control over the image block in the member profile. (active, 9 locations, image size, extra image info, count)

I don't know if this is possible with the modified 2.4.3 you have updated now (version changes with code changes would be appreciated like 2.4.4).

Originally Posted by Chuck S

What I am saying is this some hack to vbgallery etc because the default vbgallery code does not show any type of photos in a member profile.

Their are two open vbgallery issues.

This one someone reported the user fetch issue and had an error on registration and the fix for this is posted in post 2 or so of this thread.

Given that issue I installed the current code with my stock non hacked vb and I find no issues.

You keep going off on in the direction of some profile thing therefore you must be discussing a hack since vbgallery does not have any supported code that shows things in the vbulletin profile.

[Chuck S]

I do not have any plugins disabled for vbgallery my site works fine with the userinfo merge which is what I have posted and what I am concentrating here on is the bug at hand why someone gets a query error which is what is posted.

The modified version has no plugins disabled. In fact very little is modified only bug fixes for a couple things priorly posted. we have done nothing to the userinfo stuff at all here.

In the beginning of this thread the query noted the update data file has a quote where it did not belong and that has been the only change.

So I guess what I need to see is track down where you turn this profile thing on. The two addons the navbar link and photo block on forumhome turn on in addons. So we seem to be changing directions here with some kind of profile thing when I am concentrating on trying to reproduct some query error on userinfo merge which I thought was on registration.

[info5538]

Chuck,

Yes it may be two directions -- however, when I made the edits requested to resolve the MSQL errors (file edits and disabling userinfo merge), it DID remove the ability to have gallery pictures in the profile. It is quite possible they are connected.

All I can suggest is to turn on custom profile edits (a generic VB feature). I believe that will allow gallery photos on the profile (unless something in the new version disables them), but I can't be sure as I haven't tested the new "2.4.3." I've only tested my "2.4.3" I downloaded a while ago.

You can see in this same thread that I mentioned the bug fix disabling gallery profile pictures.
[Bug 2.4.3] Plugin on fetch_userinfo_query causes DB errors

I haven't seen any mysql vbgallery errors since then, but I am also missing the important gallery profile pictures ability I had before.

[Kirby]

So I guess what I need to see is track down where you turn this profile thing on.

ACP / vBGallery / Usergroup Permissions
Can view profile tab = Yes
Can view profile block = Yes
Can change profile block settings = Yes

Afterwards <forumroot>profile.php?do=vbgalleryprofile

To get an SQL error:
- Deactive vBGallery
- Create a new User via ACP
- Activate vBGallery
- View the profile of the newly created user

To see the lastpost error:
- Create a post
- Create a comment for a gallery picture
- Visit you profile and tate a look at the last post info for forum and gallery, note the time and post IDs

A workaround for both problems (witch are affectively caused by fields from table ppgal_user overriding values from table user, namely userid and lastpostid) can be found in the posting I made earlier.

[Luciano]

Originally Posted by Chuck S

So I guess what I need to see is track down where you turn this profile thing on. The two addons the navbar link and photo block on forumhome turn on in addons. So we seem to be changing directions here with some kind of profile thing when I am concentrating on trying to reproduct some query error on userinfo merge which I thought was on registration.

Well, chuck I think you are having the same problem as I had..
I did a test install to fix some other bugs.. AND omg... I did not find the place where you used to turn the profile thing on!!!..

it used to be in ACP --> vBGallery --> Modify Add-ons
(now there is only the forum home addon there)

it seems it has been removed in this version (or do I have some other setting where it gets removed)

BUT now you can activate it only in:
vBGallery --> Usergroup Permissions -->(choose a usergroup) -->
Can view profile tab --> Yes No
Can view profile block --> Yes No

Note.. you have todo this in all usergroups where you want people to see the blocks...

I think I also got confused when I seen this for the first time..

I hope this is what you meant...

Luc

[Luciano]

Thanks to Kirby for the fix..
Btw.. when trying to find a fix myself i realized that this plugin is run on MOST vbulletin pages... fetch_userinfo_query hook is ran on nearly all vbpages!!! at least all i tested.. so the query gets "heavier" on pages it is NOT needed...

what i did.. I rewrote the original plugin.. adding Kirby's fix
Advantage: its only called on pages where it is really needed.. AND there is no additional plugin needed..
Second: when zach or chuck release an official fix.. you only need to overwrite the file...

so here is my new fetch_userinfo_query.php:

Content visible to verified customers only.

You still have to replace lastpostid with gallastpostid in templates:
adv_gallery_member_stats, adv_gallery_member_block

I am more comfortable with this solution rather than using an extra plugin where you have to play with execution priority...

Drawback: you have to edit the array
$gallery_display = array("member","index","adv_index");
with the THIS_SCRIPT definitions of non-gallery pages where you want the gallery stuff to display.. here in the example you have profile, forumhome and cmps index
You only have to edit if you use others than those above.. if you dont use vba cmps you can remove the adv_index

Luc

PS: It worked as expected on my install.. let me know if there is a drawback...

[Kirby]

I am more comfortable with this solution than using an extra plugin where you have to play with execution priority...

It is definitly better than an additional plugin, I just wanted to make it as easy as possible for other users who do not feel comfortable touching the files ;-)

Btw: The code could be shortended down a bit more:

Content visible to verified customers only.

Avoids some ubnnecessary array_operstions (eg. explode)