View Full Version : Two Bugs: Price Field and Location
January 7th, 2007, 02:42 AM
I've noticed that whenever any non-numerical character is entered into the price field (i.e. $400), the entry is discarded instead of being converted to a plain number. This can easily be fixed with a PHP function.
Also, there are no location definitions for the vBulletin-integrated version:
A very small .xml plugin can take care of this :)
January 7th, 2007, 10:17 AM
This is not a bug sorry price is typecast as an INTEGER and thus if it is not an integer it is tossed away. It is actually being sanitized by the typecast function
Second is also not a product bug of Reviewpost. In fact this is a vbulletin issue and has nothing to do with our code but there is a reviewpost modification for vbulletin. In our reviewpost modifications forum is a plugin to show who's online modifications in vbulletin
January 7th, 2007, 12:41 PM
In that case, I'll need to change it myself. None of the prices users enter show up because they all include the dollar sign :(
Thanks for the plugin.
January 7th, 2007, 05:44 PM
where are you entering a price on a review? It works fine that I see. I enter a price on a review and it is input fine. In reviews.php I show this
$price = str_replace($Globals['currency'], "", $price);
$price = str_replace( ",", "", $price );
January 7th, 2007, 10:31 PM
I'm entering the price on the default "post a review" page.
I've now modified the code to fit my needs, but originally, here were the conversions:
600 > 600
$600 > 600
USD 600 > 0
600 USD > 600
This is fine, but not all web users understand the way these things work, so I'm just trying to keep things as simple as possible for them.
vBulletin® v3.8.1, Copyright ©2000-2014, Jelsoft Enterprises Ltd.