View Full Version : /forum/[forum].php style references
September 4th, 2005, 10:29 AM
Is it possible to add the definitions after "// Style references" in the forum integration code and add them into something that's user configurable similar to the language files? That way our skin settings aren't overwritten when we upgrade ReviewPost's code.
I know that the definitions work for most, but as they are skin variables and may differ from user to user it'd be nice to add them in the templates directory then just include the file in inside ib2.php for example.
Even better, how's about an "integration variables" option int he admin panel that lists the "Style References" so that we can edit them and they're stored in the DB? :)
September 4th, 2005, 01:13 PM
How are your skins overwritten? I don't quite follow that one. In a forum integration we simply map the correct variables from the forum used for the same similar class in our templates that we use
These variables would not change in the forum that I know of unless your using some non standard product that we do not integrate with in the first place on a style level. All vb and ipb and phpbb and threads among others that I know of have a set standard meaning tcat is tcat in every style blah blah blah.
I have come across in my time products that have different class calls for different templates but we do not support those products on a style level as a direct result.
We can think about being able to define them in a later update. It is easy to make a database table and form to do so the main issue we have would be excluding and including what forum which variables etc which can get extremely complicated with the number of forums we support
September 5th, 2005, 11:47 AM
Well what I mean is that style preferences in IB2.php (like definitions for row colours) are CSS dependant, so with a custom skin for the forums they may need to be changed. This means that when you upgrade the forum code, ib2.php is overwritten and any customizations you have are then lost.
Things like "$Style['catcolumn'] = "row1";" may be user defined/customised you see.
To me it'd seem to be a huge advantage to have these defined in a separate user file that's not code related so that they aren't overwritten in an upgrade.
It's just a suggestion after all ;)
September 5th, 2005, 12:11 PM
so your hacking the file got ya
September 5th, 2005, 12:19 PM
Yes, but you see what I mean? The CSS class definitions in the forum files are hard coded, and may not gel with the user's present stylesheet, so would have to be changed (no way around that one).
As they are style definitions if they were in a separate file (like languages or templates) they wouldn't have to be changed/hacked each time an update was released ;)
For example for some IB2 skin installs, the borderwrap/tableborder classes are interchanged.
September 5th, 2005, 12:40 PM
What I stated is any main stream forum has a set guideline of styles they must follow as far as class colors. We load the forums stylesheet so I do not follow you at all here. Every company that makes themes for the top forums must follow the set call names.
tcat is tcat in every vbulletin stylesheet. You can change the color anytime you want.
In ib2 if you change the color definitions you export this css file to disk and photopost loads it.
Since we load the stylesheets from the forum I do not follow.
vBulletin® v3.8.1, Copyright ©2000-2014, Jelsoft Enterprises Ltd.