View Full Version : [2.9 vBe] A couple bugz in search.php affecting searches on comment fields
April 5th, 2005, 07:51 AM
<details remove to avoid confusing users - updating build to place fixes in files)
3. I also believe that the SEARCH REVIEWS should not be radio-exclusive with the other choices. Because, for example, SEARCH ALL FIELDS does not actually search the comment/review field, so it really shouldn't belong to the same radio, or maybe it should be named differently.
April 6th, 2005, 09:01 AM
Thanks, Matt. Right you are and I'm appling the fixes shortly. The files in the build which are being updated are:
April 7th, 2005, 05:19 AM
Thanks Michael. Could you comment on the "Search All Fields" option not searching reviews - was that addressed in this update or a future one, either by function or labeling?
April 7th, 2005, 08:54 AM
I don't consider a review a "field" of a prooduct; field's are those that were posted along with the product. Reviews are somethign seperate and require a seperate search - the results from both cannot be combined into one search.
April 7th, 2005, 05:51 PM
I don't consider a review a "field" of a prooduct
Yes I know. The problem is probably the search form itself then. It doesn't say anywhere that it applies to products only. It just says "Keywords: _______ Search all fields, etc." By reviewing the code itself I came to understand that it forwards the search to different places depending upon whether the search includes comments or not.
However, anyone who comes into this blind given the layout reviewpost uses, would assume that search all fields means "search all fields." There is a lot of confusion in reviewpost with legacy code and this is probably a holdover. It could probably be clarified somewhat by having it say (without this numbering)
a. [ ]SEARCH PRODUCTS
1. All Fields
2. Title only
3. Title & Description
b. [ ]SEARCH REVIEWS
Now a, b are exclusive searches. and a1 is exclusive with a2&a3.
vBulletin® v3.8.1, Copyright ©2000-2014, Jelsoft Enterprises Ltd.