View Single Post
Old April 5th, 2010, 07:59 PM   #7 (permalink)
Andy R
Member
Verified Customer
 
Join Date: Feb 2002
Posts: 181
Quote:
In fact the only issue with vbgallery and the registration issue was a typo in the query line in the code noted in post 65.
No, in fact, here is another one!

I am talking about your code:

Code:
Content visible to verified customers only.
Quote:
Our plugin hook has nothing to do with the variable you are noting. Basically the query scans the users table and makes sure there is a gallery entry for the user in the gallery users table.
Yes, and THERE IS NO ENTRY at the point in time I am referring to!!! This breaks the variable I am referring to! Your code has NOT added the entry until "register_addmember_complete" hook:

Code:
Content visible to verified customers only.
Unfortunately the above code is inserted AFTER process_new_login() is executed after a NEW registration. VBULLETIN will populate $vbulletin->userinfo during a NEW REGISTRATION in that function. Your CODE breaks fetch_userinfo so $vbulletin->userinfo is FALSE!

This causes problems to ANY product that hooks into process_new_login. That is YOUR fault, coders should not have to write code to compensate for your errors. You are for all intents and purposes breaking that function during certain scenarios.

I have attached a flow chart to illustrate the issue because I am running out of ways to explain this.
Attached Images
File Type: jpg vbgal.jpg (33.8 KB, 7 views)
Andy R is offline   Reply With Quote