View Single Post
Old November 24th, 2009, 10:25 PM   #1 (permalink)
ktmtalk
Member
Verified Customer
 
Join Date: Oct 2009
Posts: 111
is_moderator function always returns true

in pp-inc.php there is a function called is_moderators

The very first test is:
if ( $User['adminedit'] == 1 || $Globals['modprivs'] == "yes" )
return( true );

Meaning... if the user is an admin, return true OR
if $Globals['modprivs'] == "yes" return true

Something seems whacko... the:
$Globals['modprivs'] is defined in the setup as:
Do you want moderators to have global rights?
Set this to NO if you want to assign moderators to specific categories

I wanted my mods to have global rights so I set this to "yes".

Because of this setting and the IF statement in is_moderator.... EVERYONE is being cleared as an "is_moderator".

Talk about MAJOR issues... I have normal members being tagged as an "is_moderator" because of that "$Globals['modprivs']" setting !!!!

I think there needs to be an additional IF in there based on:
$User['moderator'] == 1 )

I changed it to two separate IFs

if ( $User['adminedit'] == 1 )
{
return( true );
}

if ( $User['moderator'] == 1 && $Globals['modprivs'] == "yes" )
{
return( true );
}

.

Last edited by ktmtalk; November 24th, 2009 at 10:32 PM.
ktmtalk is offline   Reply With Quote