View Single Post
Old October 30th, 2008, 12:52 PM   #8 (permalink)
Luciano
Moderator
Verified Customer
 
Join Date: Aug 2005
Posts: 1,231
well in that case the thing is wrong as it is ...

try a username with a small s at the end.. and it will show (assuming username is Chucks) it will show: Chucks' gallery... and NOT Chucks's gallery

what i am trying to say: AS IS.. without any modification Vbgallery will do following:
if username is Chucks it will display: Chucks' Gallery
if username is ChuckS it will display: ChuckS's Gallery

whatever the correct way to write it is.. it should display the same.. no matter if the s at the end is capitalized or not.. thats all..

Luc
-----------------
PS: I know that the system doesnt know its last name or not.. i wasnt referring to the system but to english grammar rules..

if "ChuckS's Gallery" is correct.. then it should display "Chucks's Gallery" also. In that case we should remove the conditional below.

but if i recall my schooltime (i had english as a foreign language) we were told that if the word ended with an s.. it would be the ' only...
if that is correct the we keep the conditional in the code but add the vbstrtolower.

the code that does it in showimage.php original code:
if ($categorycache["$image[catid]"]['membercat'])
{
$navbits['browseimages.php?' . $vbulletin->session->vars['sessionurl'] . "c=$image[catid]&userid=$image[userid]"] = construct_phrase($vbphrase['usernames_images'], $image['username'], iif(substr($image['username'], -1) != 's', $vbphrase['plural_s']));
}

as an example... but there are more instances

Last edited by Luciano; October 30th, 2008 at 01:24 PM.
Luciano is offline   Reply With Quote