View Single Post
Old October 30th, 2008, 03:09 AM   #6 (permalink)
Luciano
Moderator
Verified Customer
 
Join Date: Aug 2005
Posts: 1,231
Quote:
Originally Posted by moonclamp View Post
Well firstly, that fix was posted years ago - and the current version of browseimages.php already contains the "fixed" code.
well i am using newest of both.. vbgallery AND vbulletin and it works!!

Are u using the current version of vbgallery?.. did you do major upgrade? small upgrade (from 2.42 => 2.43) or fresh install..
Just asking because it could be.. if you did an install from 1.02 to => 2.43 .. there could have been some issues as user infos are stored in new tables..
Anyway try to run maintainance tools in ACP.. like update names, gallery cache etc.. etc.. etc.. sometimes that helps..

- other hints to check.. :
in showimage.php look for $plurals
i had a once a plugin (another hack that was using the stringname and overwriting it.. (in your case $plurals)
do a test disabling all products except gallery..


Luc
@chuck
Quote:
Originally Posted by Chuck S View Post
The link I showed was to show that my name is indeed in the gallery breadcrumb and showing correctly
Well actually it doesn't .. there still maybe is a teeny weeny small bug..
I wouldn't have noticed if you wouldn't have posted the link...
BUT english is NOT my mother tongue...

it says: Chuck S (View all of Chuck S's images) or Chuck S's Images in the breadcrumbs..

This is correct.. because S would be your lastname.. and you would assume that there is a . at the end..
But i think it would be same if your nick was ChuckS (without the space)

in that case it should be:
ChuckS (View all of ChuckS' images) or ChuckS' Images in the breadcrumbs.. (without the trailing s)

If the nick was Chucks it would work out correctly
BUT as it doesnt check for capitalization.. it would then put out the s after the '.

ChuckS (View all of ChuckS's images) or ChuckS's Images in the breadcrumbs.. which I think is wrong.. (but maybe I am wrong)


in the code it looks for
Code:
Content visible to verified customers only.
but you have a capital S so it wont apply...

the fix would be:
As the username can contain (foreign language - if allowed by admin) special utf-8 characters we use vbstrtolower instead of strtolower ( thats vbstandard for usernames)

in browseimages AND showimage ..
replace ALL instances of
Code:
Content visible to verified customers only.
with
Code:
Content visible to verified customers only.
i think you need vbstringtolower (it uses the mb_string extension if exists.. but you dont need the mb_substr as you only get the last character if it is a non special utf-8 character i.e. 's'.

Attention there might also be a couple of iif(substr($post['musername'], -1) => would need change to iif(substr(vbstrtolower($post['musername']), -1)

I will do some test on my localhost install...

Luc

Last edited by Luciano; October 30th, 2008 at 05:40 AM.
Luciano is offline   Reply With Quote