Um ... why does the upgrade not first check to see if the user id has ALREADY been prepended to the filename? I see now that the database entries have the user id prepended twice, which means that i ran step 3 for upgrade 485 twice. My fault, but the upgrade should be more careful.
No offense, but restructuring the filesystem after a product has already been established is a Bad Idea. In this case, i can see the necessity due to hogging up too many inodes on the filesystem ... but in the least, don't you think a simple check to see if the user id has already been prepended would be helpful to prevent tacking it on a second or third time?
Another issue. Since you are now putting thumbs in dirs ... shouldn't each user have their own directory. Prepending to filenames is generally another Bad Idea. That's what directories are good for.
Sorry to vent ... but ... there you have it.
