View Single Post
Old July 12th, 2005, 09:19 AM   #9 (permalink)
Arnie
Member
Verified Customer
 
Join Date: Jun 2005
Posts: 179
Well here's one problem:

Code:
Content visible to verified customers only.
(~ lines 483-485 showproduct.php)

The third line is run even if the second IF routine runs, which nulls the second line replacing $reviewtext[$itemnum] with the unformatted text regardless. Basically the third line needs to be in the form of an ELSE statement (or just commented out if you do't use VB), or if ( VB3_ENHANCEDINT != "on" ) $reviewtext[$itemnum] = convert_returns($reviewtextline); is replaced with "if ( VB3_ENHANCEDINT != "on" ) $reviewtextline = convert_returns($reviewtextline);".

Currently when secondline is run, and $reviewtext[$itemnum] is replaced with the correctly formatted text, but then on the next line it's replaced with the unformatted string regardless.

Omegatron: There is no way that if your code is the same as the above (you even quoted it) and you are running RP with IP2 in a test environment that line breaks will work at all. I'm somewhat suspect that you've even tested this problem yourself? If a bug is reported here do you actually test a simulation deployment?

...anyway as I promised I'd do bug is now fixed chaps, just modify line 484/5 in showproduct as I described and it'll then correctly format newline chars in posted replies.

A correct code solution is:


Code:
Content visible to verified customers only.

Last edited by Arnie; July 12th, 2005 at 09:28 AM.
Arnie is offline   Reply With Quote